[MaxText.inference_mlperf] Linting (create_engine_from_config_flags needs maxengine_config_filepath set; text mode open for json.load; lazy interpolation for log messages; …)
#1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelMarks
requested review from
A9isha,
RissyRan,
SurbhiJainUSC,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
khatwanimohit,
mailvijayasingh,
mitalisi,
richjames0,
rni418,
shralex,
vipannalla,
wang2yn84,
wyzhang and
yangyuwei
as code owners
SamuelMarks
changed the title
open for json.load; lazy interpolation for log messages; …)
SamuelMarks
force-pushed
the
PKG-FIX_MaxText.inference_mlperf
branch
from
4eac9f7 to
87f9809
Compare
…axengine_config_filepath` set ; Linting (text mode `open` for `json.load`; lazy interpolation for log messages; …)
SamuelMarks
force-pushed
the
PKG-FIX_MaxText.inference_mlperf
branch
from
87f9809 to
d9c3767
Compare
SamuelMarks
changed the title
open for json.load; lazy interpolation for log messages; …)create_engine_from_config_flags needs maxengine_config_filepath set; text mode open for json.load; lazy interpolation for log messages; …)
mitalisi
approved these changes
Apr 14, 2025
shralex
approved these changes
Apr 14, 2025
copybara-service
bot
merged commit ba2a7b5
into
AI-Hypercomputer:main
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIXES (in part): #1107
For commentary see #1108
Merge this after #1482
Tests
python -m pytestandpytestshould both now work when pointed to this directory.Checklist
Before submitting this PR, please make sure (put X in square brackets):