Enable AQT quantization test#1581
Merged
Merged
Conversation
RissyRan
requested review from
A9isha,
SurbhiJainUSC,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
khatwanimohit,
mailvijayasingh,
mitalisi,
richjames0,
rni418,
shralex,
vipannalla,
wang2yn84,
wyzhang and
yangyuwei
as code owners
gobbleturk
approved these changes
Apr 15, 2025
bvandermoon
approved these changes
Apr 16, 2025
Collaborator
There was a problem hiding this comment.
LGTM pending fix of the test: https://github.com/AI-Hypercomputer/maxtext/actions/runs/14480038865/job/40616108017?pr=1581
RissyRan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@lenscloth helps fix the issue, and re-enable the AQT test.
Tests
Expect github runners to pass.
Checklist
Before submitting this PR, please make sure (put X in square brackets):