Skip to content

Update TFDS MLPerf data input pipeline#3747

Merged
copybara-service[bot] merged 2 commits into
mainfrom
perf_input_pipeline
Apr 27, 2026
Merged

Update TFDS MLPerf data input pipeline#3747
copybara-service[bot] merged 2 commits into
mainfrom
perf_input_pipeline

Conversation

@RissyRan
Copy link
Copy Markdown
Collaborator

@RissyRan RissyRan commented Apr 25, 2026

Description

Enable the dataset loading for MLPerf 6.0 DeepSeek V3.

Tests

Expect tests are green.

Local tests:

  • load new dataset: link
dataset_path=gs://mlperf-6-submission/tfds \
dataset_name='c4/en:3.0.5' \
eval_dataset_name='c4/en:3.0.5' \
  • load old dataset: link
dataset_path=gs://max-datasets-rogue \
dataset_name='c4/en:3.0.7' \
eval_dataset_name='c4/en:3.0.9' \

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...t/input_pipeline/tfds_data_processing_c4_mlperf.py 0.00% 18 Missing ⚠️
src/maxtext/input_pipeline/input_pipeline_utils.py 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@shuningjin shuningjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Left some minor comments. The gpu test has been fixed at head; please sync.

Comment thread src/maxtext/input_pipeline/tfds_data_processing_c4_mlperf.py Outdated
Comment thread src/maxtext/input_pipeline/tfds_data_processing_c4_mlperf.py Outdated
@RissyRan RissyRan force-pushed the perf_input_pipeline branch from aa3c81d to 2bebfa8 Compare April 27, 2026 16:55
Copy link
Copy Markdown
Collaborator

@suexu1025 suexu1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cases needs to adjust for compatibility

Comment thread src/maxtext/input_pipeline/tfds_data_processing_c4_mlperf.py
Comment thread src/maxtext/input_pipeline/tfds_data_processing_c4_mlperf.py
@RissyRan RissyRan force-pushed the perf_input_pipeline branch from 2bebfa8 to a67c591 Compare April 27, 2026 19:09
@RissyRan RissyRan force-pushed the perf_input_pipeline branch from a67c591 to 6c0351f Compare April 27, 2026 19:24
@copybara-service copybara-service Bot merged commit 76a7ecb into main Apr 27, 2026
27 of 29 checks passed
@copybara-service copybara-service Bot deleted the perf_input_pipeline branch April 27, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants