Skip to content

Reorder custom_nodepool_arguments for node-pool create command #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Reorder custom_nodepool_arguments for node-pool create command #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/xpk/core/nodepool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ def run_gke_node_pool_create_command(
f' --host-maintenance-interval={args.host_maintenance_interval}'
f' {capacity_args}'
' --enable-gvnic'
f' {args.custom_nodepool_arguments}'
)
if system.accelerator_type == AcceleratorType['TPU']:
command += f' --node-version={gke_node_pool_version}'
Expand Down Expand Up @@ -319,6 +318,8 @@ def run_gke_node_pool_create_command(
if args.enable_workload_identity or args.enable_gcsfuse_csi_driver:
command += ' --workload-metadata=GKE_METADATA'

command += args.custom_nodepool_arguments
Copy link
Contributor

@RoshaniN RoshaniN Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

While this looks like an acceptable change, I'm curious to know how this would make a difference to the overriding behavior of gcloud arguments. Is there a bug / example you could share to aid the PR description?

Copy link
Member Author

@scaliby scaliby Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoshaniN added more verbose description


task = f'NodepoolCreate-{node_pool_name}'
create_commands.append(command)
create_task_names.append(task)
Expand Down
Loading