From 41b35c9b78f73250fe0c5167f546aa6f85a8ce91 Mon Sep 17 00:00:00 2001 From: Feidias Ioannidis Date: Tue, 7 Oct 2025 13:18:06 +0000 Subject: [PATCH 1/2] Upload nodepool creation error log --- .github/workflows/reusable_cluster_private.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable_cluster_private.yaml b/.github/workflows/reusable_cluster_private.yaml index 61a208f53..28e68b95b 100644 --- a/.github/workflows/reusable_cluster_private.yaml +++ b/.github/workflows/reusable_cluster_private.yaml @@ -76,9 +76,16 @@ jobs: - name: Check xpk installation run: xpk --help - name: Create a Pathways-enabled private XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing. - run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}" + run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}" - name: Verify the created cluster is private run: gcloud container clusters describe ${{inputs.cluster-name}}-private --location=${{inputs.location}} --format="value(privateClusterConfig.enablePrivateNodes)" | grep 'True' || (echo 'The created cluster is not private.' && exit 1) - name: Delete the cluster created if: always() - run: python xpk.py cluster delete --cluster ${{inputs.cluster-name}}-private --zone=${{inputs.zone}} --force \ No newline at end of file + run: python xpk.py cluster delete --cluster ${{inputs.cluster-name}}-private --zone=${{inputs.zone}} --force + - name: Upload nodepool creation log + if: always() + uses: actions/upload-artifact@v4 + with: + name: private-nodepool-log-${{ inputs.run-id }} + # The path to the file to upload, using the wildcard pattern + path: /tmp/NodepoolCreate-${{inputs.cluster-name}}-private-np-* From 65ea79d07b527ccf98de4388bfa7de65cac1c084 Mon Sep 17 00:00:00 2001 From: Feidias Ioannidis Date: Tue, 7 Oct 2025 13:18:06 +0000 Subject: [PATCH 2/2] Upload nodepool creation error log --- .github/workflows/reusable_cluster_private.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable_cluster_private.yaml b/.github/workflows/reusable_cluster_private.yaml index 61a208f53..e2e3326c1 100644 --- a/.github/workflows/reusable_cluster_private.yaml +++ b/.github/workflows/reusable_cluster_private.yaml @@ -76,9 +76,16 @@ jobs: - name: Check xpk installation run: xpk --help - name: Create a Pathways-enabled private XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing. - run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}" + run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}" - name: Verify the created cluster is private run: gcloud container clusters describe ${{inputs.cluster-name}}-private --location=${{inputs.location}} --format="value(privateClusterConfig.enablePrivateNodes)" | grep 'True' || (echo 'The created cluster is not private.' && exit 1) - name: Delete the cluster created if: always() - run: python xpk.py cluster delete --cluster ${{inputs.cluster-name}}-private --zone=${{inputs.zone}} --force \ No newline at end of file + run: python xpk.py cluster delete --cluster ${{inputs.cluster-name}}-private --zone=${{inputs.zone}} --force + - name: Upload nodepool creation log + if: always() + uses: actions/upload-artifact@v4 + with: + name: private-nodepool-log-${{github.run_id}} + # The path to the file to upload, using the wildcard pattern + path: /tmp/NodepoolCreate-${{inputs.cluster-name}}-private-np-*