Skip to content

fix: Don't check flex in is_TAS_possible #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

fix: Don't check flex in is_TAS_possible #675

merged 5 commits into from
Oct 9, 2025

Conversation

@jamOne-
Copy link
Collaborator

@jamOne- jamOne- commented Oct 8, 2025 •
edited
Loading

Fixes / Features

  • c818306 by omission changed the kjob behavior. I think we should not check for flex any more. In the commit we reversed the condition, but I don't think that was correct.

Testing / Documentation

  • [ y ] Tests pass
  • [ n/a ] Appropriate changes to documentation are included in the PR

scaliby
scaliby requested changes Oct 8, 2025
View reviewed changes
@jamOne- jamOne- closed this Oct 8, 2025
@jamOne- jamOne- reopened this Oct 8, 2025
@jamOne- jamOne- requested a review from scaliby October 8, 2025 15:52
@jamOne- jamOne- changed the title refactor: Make is_TAS_possible a bit more understandable fix: Don't check flex in is_TAS_possible Oct 8, 2025
@jamOne- jamOne- enabled auto-merge (squash) October 9, 2025 09:32
@jamOne- jamOne- merged commit b29f717 into develop Oct 9, 2025
12 checks passed
@jamOne- jamOne- deleted the dominikrabij/workload-tas-annotations-refactor branch October 9, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scaliby scaliby scaliby approved these changes

@SikaGrr SikaGrr Awaiting requested review from SikaGrr

@FIoannides FIoannides Awaiting requested review from FIoannides

Assignees

No one assigned

Labels

release-bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamOne- @FIoannides @scaliby