Add missing valid TPU topologies for v4, v5p and tpu7x. #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SikaGrr
requested review from
FIoannides,
jamOne- and
scaliby
as code owners
|
🤖 Hi @SikaGrr, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
scaliby
approved these changes
Nov 14, 2025
jamOne-
reviewed
Nov 14, 2025
| supports_sub_slicing=supports_sub_slicing, | ||
| ) | ||
| system_characteristics_map[f'{prefix}-{topology}'] = system | ||
| system_characteristics_map[f'{prefix}-{num_tensorcores}'] = system |
Collaborator
There was a problem hiding this comment.
Doesn't the current change affect this use-case? Previously if someone used the -{num_tensorcores} they got the default topology. Now it'll be random (latest generated of this number of cores)? Or am I wrong and there's only one topology for each number of tensorcores?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some valid topologies are not supported by XPK. This change adds missing topologies for v4, v5p and tpu7x platforms.
Issue
b/458325393
Testing
Verified the list of generated topologies in an external script and checked validation logic with xfn.