Disable SU by default

- We plan on distributing an addon for our SU - Developers that want SU by default can export WITH_SU=true to their env - This helps with application compatibility for various services, while maintaining user flexibility Change-Id: I6d52159676f805c3698ff59c896d943a3a4b25db
AICP · Feb 10, 2017 · 284bd7e · 284bd7e
1 parent 9374895
commit 284bd7e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/configs/common.mk b/configs/common.mk
@@ -1,4 +1,6 @@
-SUPERUSER_EMBEDDED := true
+ifeq ($(WITH_SU),true)
+    SUPERUSER_EMBEDDED := true
+endif
 
 # Common overlay
 DEVICE_PACKAGE_OVERLAYS += vendor/aicp/overlay/common

diff --git a/configs/common_mini_tablet_wifionly.mk b/configs/common_mini_tablet_wifionly.mk
@@ -1,4 +1,6 @@
-SUPERUSER_EMBEDDED := true
+ifeq ($(WITH_SU),true)
+    SUPERUSER_EMBEDDED := true
+endif
 
 # Common overlay
 DEVICE_PACKAGE_OVERLAYS += vendor/aicp/overlay/common_tablet

diff --git a/configs/common_packages.mk b/configs/common_packages.mk
@@ -47,11 +47,16 @@ PRODUCT_PACKAGES += \
     PhotoPhase \
     procmem \
     procrank \
-    su \
     Superuser \
     Torch \
     VisualizationWallpapers
 
+# Conditionally build in su
+ifeq ($(WITH_SU),true)
+PRODUCT_PACKAGES += \
+    su
+endif
+
 # OmniRom packages
 PRODUCT_PACKAGES += \
     OmniStyle