New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding segmentations from FCCSW #137

Merged
merged 6 commits into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@jlingema
Contributor

jlingema commented Mar 28, 2017

In case these are useful for someone else :-)

BEGINRELEASENOTES

  • Adding GridRPhiEta a segmentation of equidistant size in R, Phi and Pseudorapidity
  • Adding GridPhiEta a segmentation of equidistant size in Phi and Pseudorapidity

ENDRELEASENOTES

@petricm

This comment has been minimized.

Member

petricm commented Mar 28, 2017

Can you also add the plugin functionality e.g. #97

@jlingema

This comment has been minimized.

Contributor

jlingema commented Mar 29, 2017

Hi Marko - I added the plugins but wasn't sure about this guy. Do you want it also added in py?

@petricm

This comment has been minimized.

Member

petricm commented Mar 29, 2017

Yes add it also there please

@MarkusFrankATcernch MarkusFrankATcernch merged commit 3cbea03 into AIDASoft:master Mar 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andresailer

This comment has been minimized.

@jlingema

This comment has been minimized.

Contributor

jlingema commented Mar 29, 2017

Missing the new TVector dependency in DDSegmentation. A bit bizarre that it works on other platforms.

Looking at the CMakeLists.txt in DDSegmentation, it is very different from the others (it is not using dd4hep_package). When anyway having to change it, should it be re-written to be in line with the others?

@andresailer

This comment has been minimized.

Member

andresailer commented Mar 29, 2017

DDSegmentation used to be a standalone package, I thought @MarkusFrankATcernch already changed it to be no longer stand alone

decibelcooper added a commit to decibelcooper/DD4hep that referenced this pull request May 3, 2018

DDG4: Geant4Handle: fixed unhandled reference to shared actions
This addresses issue AIDASoft#137.  Previously, the initial m_refCount=1 was not
being accounted for

Also, this commit removes unnecessary readoption of the Geant4Actions

decibelcooper added a commit to decibelcooper/DD4hep that referenced this pull request May 3, 2018

DDG4: Geant4Handle: fixed unhandled reference to shared actions
This addresses issue AIDASoft#137.  Previously, the initial m_refCount=1 was not
being accounted for

Also, this commit removes unnecessary readoption of the Geant4Actions

decibelcooper added a commit to decibelcooper/DD4hep that referenced this pull request May 3, 2018

DDG4: Geant4Handle: fixed unhandled reference to shared actions
This addresses issue AIDASoft#137.  Previously, the initial m_refCount=1 was not
being accounted for

Also, this commit removes unnecessary readoption of the Geant4Actions

decibelcooper added a commit to decibelcooper/DD4hep that referenced this pull request May 3, 2018

DDG4: Geant4Handle: fixed unhandled reference to shared actions
This addresses issue AIDASoft#137.  Previously, the initial m_refCount=1 was not
being accounted for

Also, this commit removes unnecessary readoption of the Geant4Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment