New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ROOT dependency in DDSegmentation #138

Merged
merged 3 commits into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@jlingema
Contributor

jlingema commented Mar 29, 2017

PR #137 introduced a ROOT dependency, leading to linker errors on Mac builds. As @andresailer suggested, I took the easy route of implementing the eta calculation directly.

BEGINRELEASENOTES

  • Direct implementation that calculates eta from cartesian coordinates
  • Fix: Add registration of Phi-Eta segmentation

ENDRELEASENOTES

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Mar 29, 2017

I will rebase now and test on gitlab all platforms. Travis only checks linux compilation and no tests.
Be careful with pulls until this is resolved.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 3615c71 into AIDASoft:master Mar 29, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Mar 29, 2017

All platforms (including MAC) passed the tests on gitlab. I think the master branch is OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment