New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ddrec #165

Merged
merged 4 commits into from Jun 15, 2017

Conversation

Projects
None yet
1 participant
@gaede
Contributor

gaede commented Jun 14, 2017

BEGINRELEASENOTES

  • started to cleanup DDRec
    • don't use LCDD::getInstance() in SurfaceManager and SurfaceHelper
    • deprecate unused(?) classes in DDRec/API and DDRec/Extensions
    • deprecate MaterialManager() using LCDD::getInstance()

ENDRELEASENOTES

gaede added some commits Jun 14, 2017

rm LCDD::getInstance from SurfaceManager/Helper
 - explicetly pass DD4hep::Geometry::LCCD to SurfaceManager c'tor
 - don't instanitate VolumeManger in SurfaceHelper but in SurfaceManager
deprecate MaterialManager() using LCDD::getInstance()
 - add MaterialManager( Volume v) instead
     - use this in Surface.cpp

@gaede gaede merged commit 7543c09 into AIDASoft:master Jun 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaede gaede deleted the gaede:cleanup_ddrec branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment