New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure linker flags and other CMake issues #196

Merged
merged 4 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@andresailer
Member

andresailer commented Jun 23, 2017

BEGINRELEASENOTES

  • CMake: add Project( DD4hep ), needed to get the correct CMAKE_CXX_COMPILER_ID on macs due to CMP0025 (cmake policy)
  • CMake: fix treatment of linker flags, they are now properly set for Linux and Macs to error when undefined functions are encountered at link time
  • CMake: fix elif --> elseif when checking threading libraries

ENDRELEASENOTES

andresailer added some commits Jun 23, 2017

Add Project( DD4hep ) call so cmake policies are properly set
Fixes issue that CMAKE_CXX_COMPILER_ID was not AppleClang on MAC
Cmake: fix elseif syntax, elif doesn't exist
the if condition was never true so 'elif' was never executed by cmake or an error would have been raised

@petricm petricm merged commit 0fc8f95 into AIDASoft:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andresailer andresailer deleted the andresailer:ensureLinkerFlags branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment