New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in some shapes #197

Merged
merged 3 commits into from Jun 23, 2017

Conversation

Projects
None yet
1 participant
@andresailer
Member

andresailer commented Jun 23, 2017

Using the default constructors for TGeoShapes does not register them to the geoManager.

BEGINRELEASENOTES

  • Fix memory leaks for Tube, EllipticalTube and Polyhedron

ENDRELEASENOTES

andresailer added some commits Jun 22, 2017

Shapes: Tube: fix memory leak
Default constructor of TGeoConeSeg (or any other TGeoShapes) do not
register the object so they are not automatically cleaned up. So we
call the constructor with parameters instead
Shapes: Polyhedron: use c'tor with parameters directly
this constructor registers the shape with the geoManager

@andresailer andresailer force-pushed the andresailer:fixMemLeaks2 branch from ac95452 to c85dca7 Jun 23, 2017

@andresailer andresailer merged commit cc4491b into AIDASoft:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andresailer andresailer deleted the andresailer:fixMemLeaks2 branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment