New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set flag=true in VolumeManager_Populator::add_entry #199

Merged
merged 2 commits into from Jul 4, 2017

Conversation

Projects
None yet
3 participants
@gaede
Contributor

gaede commented Jul 4, 2017

BEGINRELEASENOTES

  • bug fix for VolumeManagerContext::toElement() and VolumeManagerContext::placement()
    - set flag=true in VolumeManager_Populator::add_entry when
    a ContextExtension is needed, i.e. sensitive volume is not DetElement's volume
  • fixes problems in CellIDPositionConverter

ENDRELEASENOTES

@gaede gaede requested a review from MarkusFrankATcernch Jul 4, 2017

@@ -268,6 +268,7 @@ namespace dd4hep {
context->element = e;
if ( nodes.size() > 0 ) {
ContextExtension* ext = new(_getExtension(context)) ContextExtension();
context->flag=true ;

This comment has been minimized.

@andresailer

andresailer Jul 4, 2017

Member

For consistency, please use spaces for indentation, and drop the space before the semicolon.

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Jul 4, 2017

context->flag = 1;
would probably be more flexible for future extensions, which could use the other bits.

@gaede gaede merged commit b4a81e6 into AIDASoft:master Jul 4, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gaede gaede deleted the gaede:fix_volmgr branch Jul 4, 2017

@andresailer

This comment has been minimized.

Member

andresailer commented Jul 4, 2017

This breaks 2 of the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment