New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDCore: Changes to the VolumeManager interface #201

Merged
merged 3 commits into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@MarkusFrankATcernch
Contributor

MarkusFrankATcernch commented Jul 6, 2017

BEGINRELEASENOTES

DDCore: Changes to the VolumeManager interface

Recent descrepancies showed that the call to lookup a placement
from the volume manager may have an ambiguous meaning:
It may (as used until now) be the placement of thge closest
detector element - a functionality used by various tests
or be the placement of the sensitive volume itself.
So far, since each sensitive volume in the DD4hep tests
is represented by a DetElement structure, both
approaches returned the same placed volume.

Since there is the possibility to have sensitive volumes, which are not
directly connected to a single DetElement structure, this call was
split to resolve this ambiguity:

/// Lookup a physical (placed) volume identified by its 64 bit hit ID
PlacedVolume lookupVolumePlacement(VolumeID volume_id) const;
/// Lookup a physical (placed) volume of the detector element
/// containing a volume identified by its 64 bit hit ID
PlacedVolume lookupDetElementPlacement(VolumeID volume_id) const;

ENDRELEASENOTES

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Jul 6, 2017

If tomorrow morning nobody has objections, I shall merge.
Travis and gitlab finished successfully.

@gaede

This comment has been minimized.

Contributor

gaede commented Jul 6, 2017

Thanks Markus. Why not merge right away ?

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Jul 6, 2017

OK. I'll merge.

@MarkusFrankATcernch MarkusFrankATcernch merged commit eb8c815 into AIDASoft:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment