New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt LCIOEventReader for Pythia8 and Whizard2 #231

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@gaede
Contributor

gaede commented Sep 14, 2017

BEGINRELEASENOTES

  • adapt LCIOEventReader for Pythia8 and Whizard2
    • add all parent-less particles to outgoing vertex
    • fixes #226 and closes #229
    • also used for stdhep files

ENDRELEASENOTES

adapt LCIOEventReader for Pythia8 and Whizard2
 - add all parentless particles to outgoing vertex

@gaede gaede merged commit 76e5eb0 into AIDASoft:master Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaede gaede deleted the gaede:fix_lcio_reader branch Sep 14, 2017

@akiyamiyamoto

This comment has been minimized.

akiyamiyamoto commented Sep 15, 2017

ddsim-error.txt
I tried with a test whizard2 sample but failed with error message from ParticleHandler.
Last 30 lines of log output is attached.

The test whizard2 file is placed at lfn:/ilc/user/a/amiyamot/samples/whizard2_test_sample.slcio.
The file was created by whizard2, then modified gen status code of beam particles and hard partons
to 4 and 5, whizard2 can not set 4 and 5 to the status code yet.

@gaede

This comment has been minimized.

Contributor

gaede commented Sep 15, 2017

This should now really be fixed in #232. I had made the tests for this PR only for the Whizard2 file you had sent me last week - which did not yet have 4 or 5. I have not added the hard-subprocess code 5 to DDG4, as this is not really a standard but only used by Whizard.
Anyways, for stdhep and lcio input the lcio output should have arbitrary status codes correct now.

@akiyamiyamoto

This comment has been minimized.

akiyamiyamoto commented Sep 19, 2017

Thank you. It works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment