New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm heap allocation of elements in BitFieldCoder #242

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@gaede
Contributor

gaede commented Oct 6, 2017

BEGINRELEASENOTES

  • improve BitFieldCoder class
    • remove heap allocation of BitFieldElements
    • add move constructors for efficient filling of vector

ENDRELEASENOTES

@petricm petricm requested a review from MarkusFrankATcernch Oct 9, 2017

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Oct 9, 2017

I think this looks good. Please merge the request.

@petricm petricm merged commit 2478f15 into AIDASoft:master Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment