Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in input handling #389

Merged
merged 1 commit into from May 22, 2018
Merged

fix bug in input handling #389

merged 1 commit into from May 22, 2018

Conversation

petricm
Copy link

@petricm petricm commented May 22, 2018

cherry pick @gaede commit from branch rel-v01-07 to fix input handling
BEGINRELEASENOTES

ENDRELEASENOTES

Resolves #387
Closes #381

Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not also include the release notes for v01-17-01 here - as otherwise they would be missing from the history...

@petricm
Copy link
Author

petricm commented May 22, 2018

Well you are right, but if you include them, then the same bug fix will be displayed twice, thus I removed them.

@gaede
Copy link
Contributor

gaede commented May 22, 2018

... but in a sense the bug fix is applied twice, once in the branch release v01-07-01 and once in the master. This way v01-07-01 will never be documented in future releases....

@petricm petricm force-pushed the fixtau branch 2 times, most recently from b0c6dc8 to d3cc61a Compare May 22, 2018 14:48
@petricm
Copy link
Author

petricm commented May 22, 2018

Yes, you are right, it's basically good to know maybe not all patches go to master as they are superseded by some other development, so this duplication is actually welcome.

@petricm petricm merged commit f1182f5 into AIDASoft:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect treatment of documentation lines in Geant4InputHandling
2 participants