New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MegatileLayerGridXY segmentation: add segmentation parameters #204

Merged
merged 2 commits into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@danieljeans
Contributor

danieljeans commented Jul 14, 2017

BEGINRELEASENOTES

  • add ncellsX/Y as a "parameter", allowing it to be set in compact description. This change is for easier use in the case of a MultiSegmentation. (Only a uniform segmentation can be defined in this way: for more complex cases, must set by driver.)
  • change from array to std::vector to store ncells information
    ENDRELEASENOTES
@danieljeans

This comment has been minimized.

Contributor

danieljeans commented Jul 14, 2017

hmm seems to be some problem with the build
I'll look into it

@petricm

This comment has been minimized.

Member

petricm commented Jul 14, 2017

@gaede if you review and merge this by 14:00 it will be in the next build so I can update the nightly at 14:45.

@gaede gaede merged commit 2777420 into AIDASoft:master Jul 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danieljeans danieljeans deleted the danieljeans:adaptForHybridEcal branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment