New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameter for the MCParticle collection name #215

Merged
merged 3 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@jstrube
Contributor

jstrube commented Aug 13, 2017

closes #147
BEGINRELEASENOTES

  • LCIOEventReader: adding parameter for the name of the MCParticle collection: MCParticleCollectionName

ENDRELEASENOTES

Jan Strube and others added some commits Aug 13, 2017

/// list
Geant4EventReader::EventReaderStatus
dd4hep::sim::LCIOFileReader::setParameters( std::map< std::string, std::string > & parameters ) {
_getParameterValue( parameters, "MCParticleCollectionName", m_collectionName, LCIO::MCPARTICLE);

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

I think this needs to be at the end
... std::string( LCIO::MCPARTICLE ) );

@andresailer andresailer merged commit 67ccdc7 into AIDASoft:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andresailer

This comment has been minimized.

Member

andresailer commented Aug 15, 2017

Breaks gitlab CI LLVM builds, fix in the works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment