New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beampipe modifications #216

Merged
merged 3 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@Voutsi
Contributor

Voutsi commented Aug 14, 2017

BEGINRELEASENOTES

  • Adding variable "nocore" for beam pipe (with default value = false) In case the variable appears in the BP xml file as "true", the BP sections will have no core of beam material, in order that someone might add various BP walls made of different materials while avoiding G4 overlaps. Example of use:
<detector name="BeBeampipe" type="DD4hep_Beampipe_o1_v01" insideTrackingVolume="true" nocore="true" vis="BeamPipeVis">

ENDRELEASENOTES

Beam pipe driver modified, and additional field (with default value) …
…added, that controls the placement of the core (made of beam material), in order to be able to add several BP walls made of various materials
envelope.placeVolume( wallLog0, placementTransformer );
envelope.placeVolume( wallLog1, placementTransmirror );
}

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

Please put the else on the line with the closing bracket

envelope.placeVolume( wallLog0, placementTransformer );
envelope.placeVolume( wallLog1, placementTransmirror );
}

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

else on the same line

// placement as a daughter volumes of the tube
tubeLog0.placeVolume( wallLog0, Position() );
tubeLog1.placeVolume( wallLog1, Position() );
}

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

else on the same line

tubeLog1.placeVolume( wallLog1, Transform3D() );
tubeLog0.placeVolume( wallLog0, Transform3D() );
tubeLog1.placeVolume( wallLog1, Transform3D() );
}

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

else on the same line

// placement as a daughter volumes of the tube
tubeLog0.placeVolume( wallLog0, Transform3D() );
tubeLog1.placeVolume( wallLog1, Transform3D() );
}

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

else on the same line

@@ -111,7 +111,7 @@ static dd4hep::Ref_t create_element(dd4hep::Detector& description,
//Access to the XML File
xml_det_t xmlBeampipe = element;
const std::string name = xmlBeampipe.nameStr();
bool nocore = xmlBeampipe.nocore(false);

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

This means nocore is an attribute of the detector, right? What about putting nocore as part of the individual sections? Then you can still have some sections where you just want to have a single wall material automatically create the beam pipe volume.

This comment has been minimized.

@Voutsi

Voutsi Aug 14, 2017

Contributor

Yes, the idea is to put several BP detectors, the inner one (e.g. coating) with nocore=false and then several ones around it w/o core, like Be, water cooling tube, shields etc... I think that would be easier if I put it as a detector attribute, at least for the FCCee case. Your idea is to add an additional section attribute or to replace the detector attribute with a section one?

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

Ok, I see. I hadn't thought about placing two beampipe detectors. I think then it is OK for me.

}
else{

This comment has been minimized.

@andresailer

andresailer Aug 14, 2017

Member

Please put the else on the line with the closing bracket

@andresailer

This comment has been minimized.

Member

andresailer commented Aug 14, 2017

Can you post or link to an example of how the beampipe looks with nocore=true? Thanks

@andresailer andresailer changed the title from Fc cee to Beampipe modifications Aug 14, 2017

@Voutsi

This comment has been minimized.

Contributor

Voutsi commented Aug 14, 2017

You can find an example of an xml file with nocore = true at:
/afs/cern.ch/user/v/voutsina/public/Beampipe_o4_v02_test_new.xml

@andresailer

This comment has been minimized.

Member

andresailer commented Aug 14, 2017

Can you now just squash your commits, please? At least getting rid of the merge commits, and the whitespace only commits.

andresailer and others added some commits Aug 11, 2017

dd4hep_generate_rootmap: use CMAKE_INSTALL_LIBDIR if it is set
if the macro is called from other libraries this variable might be set and should be used for consistency

@Voutsi Voutsi force-pushed the Voutsi:FCCee branch from cf0fe13 to fecbeb6 Aug 15, 2017

@andresailer

This comment has been minimized.

Member

andresailer commented Aug 15, 2017

Ok, thanks for cleaning up the commits. (The commit about "rootma[" will be removed by rebasing).
Is there anything else you want to add? Otherwise I will merge.

@Voutsi

This comment has been minimized.

Contributor

Voutsi commented Aug 15, 2017

Thanks, no I don't have anything else concerning this request

@andresailer andresailer merged commit 3de754b into AIDASoft:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment