New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ROOT persistency #217

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@MarkusFrankATcernch
Contributor

MarkusFrankATcernch commented Aug 14, 2017

BEGINRELEASENOTES

Enhance ROOT Detector Description Persistency

Conditions slices from the DD4hep conditions store can now be saved to ROOT files ans named objects. Conditions persistency examples are added to the examples/Conditions section.
The examples are derived from the Telescope and CLICSiD example:

  • Conditions_Telescope_root_save
  • Conditions_Telescope_root_load_iov
  • Conditions_Telescope_root_load_pool
  • Conditions_CLICSiD_root_save_LONGTEST
  • Conditions_CLICSiD_root_load_iov_LONGTEST
  • Conditions_CLICSiD_root_load_usr_LONGTEST
  • Conditions_CLICSiD_root_load_cond_LONGTEST

Fix Handle Problem when Accessing Materials from Volumes

A cast problem was not spotted in the last commit, which manifested itself in accessing invalid materials from volumes. This commit resolves #211 , reported by @jhrdinka.

A set of tests checks this behaviour in the ClientTests: ClientTests_volume_materials_<text>, where the volume tree is scanned and for all sensitive volumes and access the corresponding materials/TGeoMedium entities from the volume object.

ENDRELEASENOTES

@MarkusFrankATcernch MarkusFrankATcernch force-pushed the MarkusFrankATcernch:master branch from c414c58 to ae9c20d Aug 14, 2017

@MarkusFrankATcernch MarkusFrankATcernch merged commit dad3412 into AIDASoft:master Aug 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@petricm

This comment has been minimized.

Member

petricm commented Aug 14, 2017

@MarkusFrankATcernch what do you mean with "Conditions persistency examples are added to the examples/Conditions section." I don't see any examples added in this PR?

@petricm

This comment has been minimized.

Member

petricm commented Aug 14, 2017

I think your initial PR included commits that were already part of #210 and once you rebased this is now gone. I think the fist part of the release notes is obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment