Skip to content

Conversation

@thefirehacker
Copy link
Member

No description provided.

jmandreoli and others added 18 commits November 29, 2020 16:51
The doc shows how to update codemirror options for the notebook cell editor, but not for the whole file editor. I have added lines 51-62 to give that information. The information comes from Stack-Overflow (and has been tested), but it has been frustratingly long to find, so I think it is worth sharing ...
example notebook: don't recommend using $$...$$ for display math
Added section for file editor configuration
do not apply asyncio patch for tornado >=6.1
allow_origin can be the wildcard '*' to allow any host

check_referer should match check_origin
Co-authored-by: Min RK <benjaminrk@gmail.com>
nudge can leak idle messages, so it could be busy->idle, or idle->busy->idle.

The important thing is that we get at least one idle message
- connect iopub first (tiny effect on the race!)
- docstrings, log details
- resolve immediately if kernel is busy, rather than setting up timeouts, futures
- use gen.with_timeout instead of separately managed timeout
- use gen.multi to wait for both futures instead of duplicated check in each handler, third Future
- add various cancel conditions (sockets closed, kernel stopped, etc.)
ensure iopub subscriptions propagate prior to accepting websocket connections
handle allow_origin='*' in check_referer
@thefirehacker thefirehacker merged commit 5c1278c into AIEdX:master Dec 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants