Implement Stardog as Backend Adapter #122

simeonackermann · 2016-07-25T09:36:25Z

This implements Stardog as new backend adapter, originally inspired by @Matthimatiker in #86

It uses Guzzle 5.3 as HTTP client to request Stardog via HTTP Interface.

All operations as used for Virtuoso to query the store, add or remove statements should be supported. If versioning is enabled (default) an additional SQL ZendDB store is required.

The implemented integration test (make test-integration-stardog) completes with success.

Stardog can be installed as Docker Container from https://github.com/Dockerizing/Stardog

config.ini for Erfurt with Stardog should look like:

store.backend = stardog
versioning = true

; Stardog backend
store.stardog.base_url   = http://localhost:5820
store.stardog.username   = admin
store.stardog.password   = admin
store.stardog.database   = erfurt

; ZendDB
store.zenddb.dbname   = erfurt
store.zenddb.username = root
store.zenddb.password = password
store.zenddb.dbtype   = mysql
store.zenddb.host     = localhost

k00ni · 2016-07-25T09:43:41Z

Guzzle installation seems to fail in Travis, can you please look into that @simeonackermann ?

simeonackermann · 2016-07-25T10:01:02Z

Guzzle requires PHP >= 5.5.0, but Travis was used with 5.4. Could this be updated?

k00ni · 2016-07-25T10:13:56Z

Maybe we use Guzzle in version 5.3.1 for now? It supports PHP 5.4.

simeonackermann · 2016-07-25T10:47:03Z

Unfortunately its not compatible with current implementation, I have to change some methods first...

simeonackermann · 2016-07-27T08:41:26Z

Could you please recheck Travis?

white-gecko · 2016-07-27T11:29:12Z

Travis didn't build this pull request, maybe you have to resolve the merge conflict first. For instance by re-basing on the current develop.

simeonackermann · 2016-07-27T13:58:54Z

Ok, thanks for the hint, Travis build with success :)

k00ni · 2016-08-01T07:36:45Z

@simeonackermann: Please fix the conflicts (again) so that we can merge your code.

pfrischmuth · 2016-08-05T09:31:39Z

Can you please rebase your commits on the current develop branch instead of merging it in? At least we want to get rid of the "Merge..." commits, but maybe you can also rework your commits into logical chunks?

Use rebase -i develop for this purpose (assuming that your local develop branch is up to date with the AKSW/Erfurt develop branch.

pfrischmuth · 2016-08-08T13:30:45Z

composer.json

@@ -26,7 +26,8 @@
        "pdepend/pdepend": "2.2.*",
        "phploc/phploc": "2.1.*",
        "phpmd/phpmd": "2.4.*",
-        "white-gecko/arrays": "*"
+        "white-gecko/arrays": "*",
+	"guzzlehttp/guzzle": "5.3.1"


Please fix indentation, use spaces instead of tabs

pfrischmuth · 2016-08-08T14:36:44Z

manual review commits: FAILED
- does not support blank nodes in the current version, but the Virtuoso adapter neither, we should fix this seperately
- composer.json: fix comments
- library/Erfurt/Store/Adapter/Stardog.php: fix comments
- library/Erfurt/Store/Adapter/Stardog/ApiClient.php: fix comments
- tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php: fix comments
check style with phpcs on changed files (vendor/bin/phpcs ): FAILED
- library/Erfurt/Store/Adapter/Stardog.php: FOUND 88 ERRORS AND 1 WARNING AFFECTING 82 LINES
- library/Erfurt/Store/Adapter/Stardog/ApiClient.php: FOUND 28 ERRORS AFFECTING 24 LINES
- tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php: FOUND 25 ERRORS AND 4 WARNINGS AFFECTING 29 LINES
further manual tests:
- consider: were unit/integration tests created that test the feature/fix?
  - test for store adapter was added, but not for api client

Please take the following actions:

Required for merge

Fix comments I added manually to the lines:
- composer.json: fix comments
- library/Erfurt/Store/Adapter/Stardog.php: fix comments
- library/Erfurt/Store/Adapter/Stardog/ApiClient.php: fix comments
- tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php: fix comments
Fix phpcs issues:
- library/Erfurt/Store/Adapter/Stardog.php: FOUND 88 ERRORS AND 1 WARNING AFFECTING 82 LINES
- library/Erfurt/Store/Adapter/Stardog/ApiClient.php: FOUND 28 ERRORS AFFECTING 24 LINES
- tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php: FOUND 25 ERRORS AND 4 WARNINGS AFFECTING 29 LINES
Please rework Stardog@sqlConnection method
- currently hard codes ini files
- does not work with test environment
- please use $app->getConfig(), then change value on the config object directly
- I tested the above approach locally and it seems to work

Optional

Please reword commit message title prior merge
- details can stay as they are, but title should not contain "Initial..." but something like "Add support for Stardog as backend"
Please consider creating a unit test for the stardog api client class
- maybe you can add at least the infrastructure for further tests
- this means add a unit test class and provide a mechanism to exchange the HTTP client with a mock (http://docs.guzzlephp.org/en/latest/testing.html)
- maybe add one simple test as an example

k00ni · 2016-08-08T14:39:03Z

@simeonackermann: Please fix mentioned points of @pfrischmuth before start researching the elevator task.

simeonackermann · 2016-08-09T10:44:08Z

@pfrischmuth : The integration test is mainly taken from virtuoso integration test and php codesniffer marks too long lines as:

$value    = <<<EOT
Over the past 3 years, the semantic web activity has gained momentum with the widespread publishing of structured data as RDF. The Linked Data paradigm has therefore evolved from a practical research idea into a very promising candidate for addressing one of the biggest challenges in the area of intelligent information management: the exploitation of the Web as a platform for data and information integration in addition to document search. To translate this initial success into a world-scale disruptive reality, encompassing the Web 2.0 world and enterprise data alike, the following research challenges need to be addressed: improve coherence and quality of data published on the Web, close the performance gap between relational and RDF data management, establish trust on the Linked Data Web and generally lower the entrance barrier for data publishers and users. With partners among those who initiated and strongly supported the Linked Open Data initiative, the LOD2 project aims at tackling these challenges by developing:
<ol>
<li>enterprise-ready tools and methodologies for exposing and managing very large amounts of structured information on the Data Web,</li>
<li>a testbed and bootstrap network of high-quality multi-domain, multi-lingual ontologies from sources such as Wikipedia and OpenStreetMap.</li>
<li>algorithms based on machine learning for automatically interlinking and fusing data from the Web.</li>
<li>standards and methods for reliably tracking provenance, ensuring privacy and data security as well as for assessing the quality of information.</li>
<li>adaptive tools for searching, browsing, and authoring of Linked Data.</li>
</ol>
We will integrate and syndicate linked data with large-scale, existing applications and showcase the benefits in the three application scenarios of media & publishing, corporate data intranets and eGovernment. The resulting tools, methods and data sets have the potential to change the Web as we know it today.
EOT;

A workaround might be:

$value    = 'Over the past 3 years, the semantic web activity has gained momentum with the widespread '.
            'publishing of structured data as RDF. The Linked Data paradigm has therefore evolved from a practical '.
            'research idea into a very promising candidate for addressing one of the biggest challenges in the area '.
            'of intelligent information management: the exploitation of the Web as a platform for data and '.
            'information integration in addition to document search. To translate this initial success into a '.
            'world-scale disruptive reality, encompassing the Web 2.0 world and enterprise data alike, the following '.
            'research challenges need to be addressed: improve coherence and quality of data published on the Web, '.
            'close the performance gap between relational and RDF data management, establish trust on the Linked Data '.
            'Web and generally lower the entrance barrier for data publishers and users. With partners among those '.
            'who initiated and strongly supported the Linked Open Data initiative, the LOD2 project aims at tackling '.
            'these challenges by developing:'.PHP_EOL.
            '<ol>'.PHP_EOL.
            '<li>enterprise-ready tools and methodologies for exposing and managing very large amounts of structured '.
                'information on the Data Web,</li>'.PHP_EOL.
            '<li>a testbed and bootstrap network of high-quality multi-domain, multi-lingual ontologies from sources '.
                'such as Wikipedia and OpenStreetMap.</li>'.PHP_EOL.
            '<li>algorithms based on machine learning for automatically interlinking and fusing data from the '.
                'Web.</li>'.PHP_EOL.
            '<li>standards and methods for reliably tracking provenance, ensuring privacy and data security as well '.
                'as for assessing the quality of information.</li>'.PHP_EOL.
            '<li>adaptive tools for searching, browsing, and authoring of Linked Data.</li>'.PHP_EOL.
            '</ol>'.PHP_EOL.
            'We will integrate and syndicate linked data with large-scale, existing applications and showcase the '.
            'benefits in the three application scenarios of media & publishing, corporate data intranets and '.
            'eGovernment. The resulting tools, methods and data sets have the potential to change the Web as we '.
            'know it today.';

But I think this is not really better to read...

k00ni · 2016-08-09T11:01:48Z

But I think this is not really better to read...

Maybe not better, but now its align with the coding standard. And if you want to read it, you can do that on a fixed screen area (max. 120 chars in the width?). In the older version you need to scroll far to the right, which is very annoying.

pfrischmuth · 2016-08-12T11:22:45Z

FAILED manual review commits:
- composer.json FIXED
- library/Erfurt/Store/Adapter/Stardog.php: FIXED
- library/Erfurt/Store/Adapter/Stardog/ApiClient.php: FIXED
- tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php: FIXED
- tests/unit/Erfurt/Store/Adapter/StardogApiClientTest.php
  - naming should be tests/unit/Erfurt/Store/Adapter/Stardog/ApiClientTest.php
  - currently not a unit test, since it requires a running stardog instance
check style with phpcs on changed files (vendor/bin/phpcs )
- style issues have been fixed
FAILED check unit tests:
- develop Branch: Tests: 672, Assertions: 1350, Incomplete: 3, Skipped: 1
- Pull Request: Tests: 676, Assertions: 1350, Incomplete: 3, Skipped: 5
- 4 new tests, all 4 tests skipped, since they currently require stardog backend
check integration tests mysql:
- develop Branch: Tests: 63, Assertions: 5834, Skipped: 7
- Pull Request: Tests: 68, Assertions: 5834, Skipped: 12
- 5 new skipped tests, OK because new tests are stardog integration tests
check integration tests virtuoso:
- develop Branch: Tests: 63, Assertions: 224, Skipped: 9
- Pull Request: Tests: 68, Assertions: 224, Skipped: 14
- 5 new skipped tests, OK because new tests are stardog integration tests
FAILED check integration tests stardog:
- develop Branch: Tests: 63, Assertions: 0, Errors: 63
- Pull Request: Tests: 68, Assertions: 203, Failures: 1, Errors: 6, Skipped: 20
- test errors on develop branch are expected, since there the backend dows not yet exist
- I get 6 errors and 1 failure when I run the integration tests on the pull request branch

Final required actions before merge

fix the integration tests
either remove api client unit test again (such that we can quickly merge this pull request)
or convert it into a unit test and fix the class name and locations of the test (should be tests/unit/Erfurt/Store/Adapter/Stardog/ApiClientTest.php)
below you find an example how the setUp method might look for a unit test

public function setUp()
{
    $mock = new MockHandler([
        new Response(200, ['X-Foo' => 'Bar']),
        new Response(202, ['Content-Length' => 0]),
        new RequestException("Error Communicating with Server", new Request('GET', 'test'))
    ]);
    $handler = HandlerStack::create($mock);

    $config = $this->getTestConfig()->store->stardog->toArray();
    $config['handler'] = $handler;

    $this->fixture = new Erfurt_Store_Adapter_Stardog_ApiClient($config);
}

simeonackermann · 2016-08-12T13:21:42Z

Hm, my integration tests completes OK, with: Tests: 68, Assertions: 219, Skipped: 16 and no errors for me...

simeonackermann · 2016-08-12T13:32:55Z

Could you please post the test error log?

pfrischmuth · 2016-08-12T13:39:15Z

When I run the tests, the output is not deterministic... the number of errors/failures differ from time to time.

I run stardog and mysql in a docker and run the test with docker also.

The commnad is: docker run --rm -vpwd:/var/www -e EF_STORE_ADAPTER=stardog --link ontowiki-devenv-stardog-test:stardog-test --link ontowiki-devenv-mysql-test:mysql-test --net devenv_default ontowiki-devenv/phpserver /bin/sh -c 'cd /var/www && php vendor/bin/phpunit --testsuite "Erfurt Integration Tests"'

The output is:

PHPUnit 4.5.1 by Sebastian Bergmann and contributors.

Configuration read from /var/www/phpunit.xml

........S...............ES.S..SSSS.E.S...SSSSSSS..S.SS.E......... 65 / 68 ( 95%)
...

Time: 32.08 seconds, Memory: 25.75MB

There were 3 errors:

1) Erfurt_Rdf_ModelIntegrationTest::testSetGetOption
Erfurt_Store_Exception: Failed creating the model.

/var/www/library/Erfurt/Store.php:1155
/var/www/tests/integration/Erfurt/Rdf/ModelIntegrationTest.php:126

2) Erfurt_Store_Adapter_SparqlIntegrationTest::testSparqlWithDbPediaEndpoint
Erfurt_Store_Adapter_Exception: SPARQL Error with query: SELECT DISTINCT ?g { GRAPH ?g { ?s ?p ?o . } }

/var/www/library/Erfurt/Store/Adapter/Stardog/ApiClient.php:193
/var/www/library/Erfurt/Store/Adapter/Stardog.php:341
/var/www/library/Erfurt/Store/Adapter/Stardog.php:356
/var/www/library/Erfurt/Store.php:1393
/var/www/library/Erfurt/Store.php:1039
/var/www/library/Erfurt/Store.php:1166
/var/www/library/Erfurt/Store.php:428
/var/www/library/Erfurt/Store.php:1046
/var/www/library/Erfurt/App.php:547
/var/www/library/Erfurt/Store.php:758
/var/www/tests/unit/Erfurt/TestCase.php:32

3) Erfurt_StoreIntegrationTest::testSparqlQueryWithSpecialCharUriIssue579
Erfurt_Store_Adapter_Exception: SPARQL Error with query: DROP SILENT GRAPH <http://ns.ontowiki.net/SysOnt/>

/var/www/library/Erfurt/Store/Adapter/Stardog/ApiClient.php:193
/var/www/library/Erfurt/Store/Adapter/Stardog.php:254
/var/www/library/Erfurt/Store.php:745
/var/www/tests/unit/Erfurt/TestCase.php:33

--

There were 18 skipped tests:

1) Erfurt_AppIntegrationTest::testGetStoreWithCleanDatabase
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/unit/Erfurt/TestCase.php:118
/var/www/tests/integration/Erfurt/AppIntegrationTest.php:113

2) Erfurt_Rdf_ModelIntegrationTest::testIsEditableWithZendDbAndAnonymousUserIssue774
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/Rdf/ModelIntegrationTest.php:143

3) Erfurt_Rdf_ResourceIntegrationTest::testGetQualifiedName
An Erfurt_Store_Exception occurred when establishing a connection: SPARQL Error with query: SELECT DISTINCT ?g { GRAPH ?g { ?s ?p ?o . } }

/var/www/tests/unit/Erfurt/TestCase.php:102
/var/www/tests/integration/Erfurt/Rdf/ResourceIntegrationTest.php:30

4) Erfurt_Sparql_EngineDbIntegrationTest::testOdFmiLimitQueryWithZendDbIssue782WithLimit
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/Sparql/EngineDbIntegrationTest.php:13

5) Erfurt_Sparql_EngineDbIntegrationTest::testOdFmiLimitQueryWithZendDbIssue782WithoutLimit
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/Sparql/EngineDbIntegrationTest.php:60

6) Erfurt_Store_Adapter_EfZendDbIntegrationTest::testSparqlQuery
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/Store/Adapter/EfZendDbIntegrationTest.php:8

7) Erfurt_Store_Adapter_EfZendDbIntegrationTest::testSerialization
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/Store/Adapter/EfZendDbIntegrationTest.php:8

8) Erfurt_Store_Adapter_StardogIntegrationTest::testAddStatementWithUriObject
An Erfurt_Store_Exception occurred when establishing a connection: SPARQL Error with query: SELECT DISTINCT ?g { GRAPH ?g { ?s ?p ?o . } }

/var/www/tests/unit/Erfurt/TestCase.php:102
/var/www/tests/unit/Erfurt/TestCase.php:177
/var/www/tests/integration/Erfurt/Store/Adapter/StardogIntegrationTest.php:18

9) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testInstantiation
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

10) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testListTables
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

11) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testAddStatementWithUriObject
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

12) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testAddStatementsWithLiteralObject
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

13) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testBuildLiteralString
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

14) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testBuildTripleString
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

15) Erfurt_Store_Adapter_VirtuosoIntegrationTest::testImportRdfWithUrlAndRdfXml302After303GithubOntoWikiIssue101
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:154
/var/www/tests/integration/Erfurt/Store/Adapter/VirtuosoIntegrationTest.php:18

16) Erfurt_StoreIntegrationTest::testCheckSetupWithZendDb
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/unit/Erfurt/TestCase.php:118
/var/www/tests/integration/Erfurt/StoreIntegrationTest.php:111

17) Erfurt_StoreIntegrationTest::testSparqlQueryWithCountQueryAndEmptyResultIssue174
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/StoreIntegrationTest.php:140

18) Erfurt_StoreIntegrationTest::testSparqlQueryWithCountAndFromIssue174
Skipped since other backend is under test.

/var/www/tests/unit/Erfurt/TestCase.php:164
/var/www/tests/integration/Erfurt/StoreIntegrationTest.php:154

FAILURES!
Tests: 68, Assertions: 211, Errors: 3, Skipped: 18.

pfrischmuth · 2016-08-15T17:18:45Z

check unit tests:
- develop Branch: Tests: 672, Assertions: 1350, Incomplete: 3, Skipped: 1
- Pull Request: Tests: 672, Assertions: 1350, Incomplete: 3, Skipped: 1
check integration tests mysql:
- develop Branch: Tests: 63, Assertions: 5834, Skipped: 7
- Pull Request: Tests: 68, Assertions: 5834, Skipped: 12
check integration tests virtuoso:
- develop Branch: Tests: 63, Assertions: 224, Skipped: 9
- Pull Request: Tests: 68, Assertions: 224, Skipped: 14
check integration tests stardog:
- Pull Request: Tests: 68, Assertions: 219, Skipped: 16
FAILED further manual tests:
- manually test OntoWiki with stardog backend:
  - when I add a new knowledge base I got the following error: Fatal error: Call to undefined function GuzzleHttp\Psr7\str() in /var/www/vendor/aksw/erfurt/library/Erfurt/Store/Adapter/Stardog/ApiClient.php on line 189

simeonackermann · 2016-08-16T10:42:21Z

The Psr7 method is from previous guzzle version an needs to removed. But even without I get an error like:

SPARQL Error: HTTP/1.1 406 Not Acceptable Content-Length: 0 with query: 
SELECT ?parent ?child FROM <http://example.org/> 
WHERE { ?child <http://www.w3.org/2000/01/rdf-schema#subClassOf> ?parent. 
OPTIONAL {?child <http://ns.ontowiki.net/SysOnt/order> ?order} 
FILTER ( ?parent IN (<http://rdfs.org/sioc/types#Comment>) ) } ORDER BY ASC(?order)

simeonackermann · 2016-08-16T15:18:16Z

Last commit fixes undefined function, but still having some problems with OntoWiki.
After select a knowledge base a screens gets blank with an error: Error on bootstrapping application: Zend_Session::start() - /var/www/vendor/zendframework/zendframework1/library/Zend/Session.php(Line:482): Error #2 session_start(): Failed to decode session object. Session has been destroyed

pfrischmuth · 2016-08-17T13:03:07Z

With your latest fix I can run OntoWiki with Stardog backend without errors.
Have you tried to run it with a fresh browser session?

When I try to execute a SPARQL query SELECT * FROM <http://ontowiki.local/dataset/> WHERE { ?s ?p ?o } on a model however, I get zero results. When I run the same query in the Stardog console directly I get two triples (rdf:type and rdfs:label).
To reproduce this, just create an empty new knowldge base and add a label.
When I test the same with Virtuoso, I get the two triples as expected.

- testet with Stardog >=4.0.1 (available via Docker) - use Zend_Http_Client as http request client - add sample config.ini - add integration tests - currently no unit tests - currently no native rdf import/export - code formatted with php code sniffer

simeonackermann · 2016-08-19T08:23:31Z

Beside the wrong Sparql results I still had the issue with the destroyed Zend session (tried a lot to fix it but doesnt found the problem). I only figured out that something with Guzzle caused my issue, so I replaced Guzzle with the Zend_Http_Client. Now everything works fine for me.

pfrischmuth · 2016-08-19T09:56:35Z

library/Erfurt/Store/Adapter/Stardog/ApiClient.php

+        if ( ! isset($options['base_url']) ) {
+            throw new Erfurt_Store_Adapter_Exception('Your config.ini lacks a store.stardog.base_url parameter.');
+        }
+        $this->_baseUrl .= ( substr($options['base_url'], -1) == "/" ) ? $options['base_url'] : $options['base_url'] . "/";


Please fix to long line

pfrischmuth · 2016-08-19T10:10:09Z

check style with phpcs on changed files (vendor/bin/phpcs )
check unit tests:
- develop Branch: Tests: 672, Assertions: 1350, Incomplete: 3, Skipped: 1
- Pull Request: Tests: 672, Assertions: 1350, Incomplete: 3, Skipped: 1
check integration tests mysql:
- develop Branch: Tests: 63, Assertions: 5834, Skipped: 7
- Pull Request: Tests: 68, Assertions: 5834, Skipped: 12
check integration tests virtuoso:
- develop Branch: Tests: 63, Assertions: 224, Skipped: 9
- Pull Request: Tests: 68, Assertions: 224, Skipped: 14
check integration tests stardog:
- Pull Request: Tests: 68, Assertions: 219, Skipped: 16
further manual tests:
- manually test OntoWiki with stardog backend: everything seems to work now

pfrischmuth · 2016-08-19T10:10:18Z

LGTM

k00ni · 2016-08-19T12:27:33Z

Thanks guys! 👍

pfrischmuth self-assigned this Aug 2, 2016

pfrischmuth added this to the v1.8 milestone Aug 2, 2016

simeonackermann force-pushed the feature/stardog branch 2 times, most recently from 5686b7f to c459882 Compare August 6, 2016 07:55

pfrischmuth reviewed Aug 8, 2016
View reviewed changes

simeonackermann force-pushed the feature/stardog branch from c459882 to 4d90a62 Compare August 9, 2016 21:40

simeonackermann force-pushed the feature/stardog branch from 4d90a62 to 3105977 Compare August 15, 2016 12:47

simeonackermann force-pushed the feature/stardog branch from 3105977 to ebe643c Compare August 16, 2016 15:12

Add Stardog as new backend adapter

7eed25a

- testet with Stardog >=4.0.1 (available via Docker) - use Zend_Http_Client as http request client - add sample config.ini - add integration tests - currently no unit tests - currently no native rdf import/export - code formatted with php code sniffer

simeonackermann force-pushed the feature/stardog branch from ebe643c to 5aefd29 Compare August 19, 2016 08:12

pfrischmuth reviewed Aug 19, 2016
View reviewed changes

Replace Guzzle with Zend_Http_Client as http client

3799657

simeonackermann force-pushed the feature/stardog branch from 5aefd29 to 3799657 Compare August 19, 2016 10:01

pfrischmuth merged commit f651bf5 into AKSW:develop Aug 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Stardog as Backend Adapter #122

Implement Stardog as Backend Adapter #122

simeonackermann commented Jul 25, 2016 •

edited

k00ni commented Jul 25, 2016 •

edited

simeonackermann commented Jul 25, 2016

k00ni commented Jul 25, 2016

simeonackermann commented Jul 25, 2016

simeonackermann commented Jul 27, 2016

white-gecko commented Jul 27, 2016

simeonackermann commented Jul 27, 2016

k00ni commented Aug 1, 2016

pfrischmuth commented Aug 5, 2016

pfrischmuth Aug 8, 2016

pfrischmuth commented Aug 8, 2016 •

edited by k00ni

k00ni commented Aug 8, 2016

simeonackermann commented Aug 9, 2016 •

edited

k00ni commented Aug 9, 2016

pfrischmuth commented Aug 12, 2016

simeonackermann commented Aug 12, 2016

simeonackermann commented Aug 12, 2016

pfrischmuth commented Aug 12, 2016

pfrischmuth commented Aug 15, 2016

simeonackermann commented Aug 16, 2016

simeonackermann commented Aug 16, 2016

pfrischmuth commented Aug 17, 2016

simeonackermann commented Aug 19, 2016

pfrischmuth Aug 19, 2016

pfrischmuth commented Aug 19, 2016

pfrischmuth commented Aug 19, 2016

k00ni commented Aug 19, 2016

Implement Stardog as Backend Adapter #122

Implement Stardog as Backend Adapter #122

Conversation

simeonackermann commented Jul 25, 2016 • edited

k00ni commented Jul 25, 2016 • edited

simeonackermann commented Jul 25, 2016

k00ni commented Jul 25, 2016

simeonackermann commented Jul 25, 2016

simeonackermann commented Jul 27, 2016

white-gecko commented Jul 27, 2016

simeonackermann commented Jul 27, 2016

k00ni commented Aug 1, 2016

pfrischmuth commented Aug 5, 2016

pfrischmuth Aug 8, 2016

Choose a reason for hiding this comment

pfrischmuth commented Aug 8, 2016 • edited by k00ni

Required for merge

Optional

k00ni commented Aug 8, 2016

simeonackermann commented Aug 9, 2016 • edited

k00ni commented Aug 9, 2016

pfrischmuth commented Aug 12, 2016

Final required actions before merge

simeonackermann commented Aug 12, 2016

simeonackermann commented Aug 12, 2016

pfrischmuth commented Aug 12, 2016

pfrischmuth commented Aug 15, 2016

simeonackermann commented Aug 16, 2016

simeonackermann commented Aug 16, 2016

pfrischmuth commented Aug 17, 2016

simeonackermann commented Aug 19, 2016

pfrischmuth Aug 19, 2016

Choose a reason for hiding this comment

pfrischmuth commented Aug 19, 2016

pfrischmuth commented Aug 19, 2016

k00ni commented Aug 19, 2016

simeonackermann commented Jul 25, 2016 •

edited

k00ni commented Jul 25, 2016 •

edited

pfrischmuth commented Aug 8, 2016 •

edited by k00ni

simeonackermann commented Aug 9, 2016 •

edited