New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a new .ini entry to enable/disable the logger #404

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@shinobu
Collaborator

shinobu commented Oct 27, 2016

This pull requests adds the log.enable into the config and changes the referring lines in the code from log.level checks to log.enable checks and adds the entry into the about page

@white-gecko
  • manual review commits
  • manual check that log enable/disable works
    • it works for ontowiki.log
    • erfurt.log and query.log is still active, if log.enabled = false
  • check unit tests:
    • OK (86 tests, 154 assertions)
  • check integration tests mysql (skipped)
  • check integration tests virtuoso:
    • FAILURES! Tests: 27, Assertions: 138, Errors: 1.

Please also implement the same behavior for log.enabled = false as it is form log.level = 0. This means, also the erfurt logs should be disabled.

@shinobu

This comment has been minimized.

Show comment
Hide comment
Collaborator

shinobu commented Nov 12, 2016

@white-gecko white-gecko self-assigned this May 2, 2017

@white-gecko white-gecko modified the milestone: 1.1 May 16, 2017

@white-gecko

This comment has been minimized.

Show comment
Hide comment
@white-gecko

white-gecko Jul 10, 2017

Member

executed tests rebased to develop (9c20df6)

  • manual review commits
  • manual check that log enable/disable works
  • check unit tests:
    • OK (86 tests, 154 assertions)
  • check integration tests virtuoso:
    • OK (45 tests, 229 assertions)
  • check integration tests mysql:
    • OK (45 tests, 229 assertions)
  • check extension tests:
    • OK (11 tests, 59 assertions)
Member

white-gecko commented Jul 10, 2017

executed tests rebased to develop (9c20df6)

  • manual review commits
  • manual check that log enable/disable works
  • check unit tests:
    • OK (86 tests, 154 assertions)
  • check integration tests virtuoso:
    • OK (45 tests, 229 assertions)
  • check integration tests mysql:
    • OK (45 tests, 229 assertions)
  • check extension tests:
    • OK (11 tests, 59 assertions)
@white-gecko

Still disabling log doesn't disable erfurt and query log.

@shinobu

This comment has been minimized.

Show comment
Hide comment
@shinobu

shinobu Jul 10, 2017

Collaborator

white-gecko did you chose the correct Erfurt version? The pr AKSW/Erfurt#135 in Erfurt isnt merged yet either

*edit

I tested it locally and it does work for me
The About page shows, that the logger is deactivated
Setting the log.level to 7 and creating a knowledgebase/triple -> no logs
Turning the Logger back on and doing the same -> logs

Collaborator

shinobu commented Jul 10, 2017

white-gecko did you chose the correct Erfurt version? The pr AKSW/Erfurt#135 in Erfurt isnt merged yet either

*edit

I tested it locally and it does work for me
The About page shows, that the logger is deactivated
Setting the log.level to 7 and creating a knowledgebase/triple -> no logs
Turning the Logger back on and doing the same -> logs

@white-gecko white-gecko merged commit 146af80 into develop Jul 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@white-gecko white-gecko deleted the feature/LogEnableEntry branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment