New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] RHS GREF compatibility #16
Conversation
At the moment all groups are defined. However, for the following factions have entries in CfgGroups that share the same group name:
Example: Is there a way to distinguish them or should this be changed in RHS? Edit: one could technically rename them and make an alias. How would that affect needs to be tested. What do you think @SpyderBlack723?
|
I believe even if they have the same name, it will work as the function that grabs group names checks to make sure they belong to the desired faction (I think.. this was implemented when rhs insurgents had the same issue..). Although the solution you posted would probably work fine as well. |
Yes, but in this case these are groups that belong to the same faction. Therefore, making an alias seems to be then the only viable solution. |
Then yes, creating a derivative class such as
Would probably be your best option. |
@TheMagnetar - gaz66 groups are renamed in next rhs version which should be available soon ;) |
@reyhard - MistyRonin informed me privately. Thanks for taking the time to fix this!! |
@TheMagnetar are you waiting for the next RHS update or are you stuck on something? 😊 |
Just waiting on the update. |
Updated today. Changelog notes "Fixed config inheritance errors with the new APEX config system". Hopefully this refers to the issue above? |
I will check during the weekend. |
I can confirm this was not "fixed". I think then the only option would be to use an alias for the conflicting group definitions. |
It seems that duplicate group names don't matter at all. All the group functions (should) use the full config path to get the list of units to spawn. Here's a list of all the duplicate groups in A3 with RHS loaded: http://pastebin.com/raw/5BaRUq1G. If it does cause problems then it's probably an issue on ALiVE's side tbh. |
Fairly certain the issue stemmed from certain groups not properly overwriting their side attribute when they were inheriting from a different side's groups. Can someone confirm whether or not that was fixed? |
The |
@TheMagnetar are you still planning to complete the faction mappings? The duplicate groups is an issue that will have to be solved on ALiVE's end so the mappings can be finalized with the current RHS configs. |
Yes, once I get back from holidays ;) |
If anyone takes this up, it's probably easier to just use the ORBAT Creator for this (aside from the static data). |
That is what I was looking into. I am currently testing some stuff. |
You may want to add the rhs_ussocom faction to that list (The MARSOC/SF grouping for blufor). |
Almost done. What would you prefere, staticData or Orbat outputs? |
Staticdata for baking into ALiVE. Orbatterer outputs would be useful for people who want to fiddle with it but they need to be run in the description.ext |
Now that RHS has been updated, is this still needed and if so what still needs to be done? |
FYI, I've used the ORBAT to make ALiVE Compatible groups for RHS GREF CDF Ground Forces, CDF UN Peacekeepers, RHS ARFAF VMF Marines, RHS USAF Socom MARSOC, RHS GREF Nationalist Troops. I don't know if ORBAT created groups are useful but I can send them to you if needed. |
Unfortunately they're not at the moment as they can't be exported in the format used by static data. If Spyder changes that (he already mentioned it today!) then we could use your versions to generate the export. |
When merged this pull request will add compatibility for the factions within RHS GREF (partially closes #15).
TODO:
When OK for the core dev-team I would prefer to work with a separate file that is included in "addons/main/static/staticData.sqf". Meanwhile, can the "WIP" and "needs testing" labels be added?