README: fix ovmf python not found with a patch instead of system-wide… #27
Conversation
|
Congratulations on your first patch, @ZenithalHourlyRate! 🥇 Good idea, but I don't thinking adding a patch in the README.md is the best course of action. What happens when OVMF changes and the patch does not apply anymore? If you want, we can instead add a note in the lines of "... if your error involves still not finding Python, you may try to...". This is, instead of providing a patch that fixes it, we tell developers something they can try. If you like the idea, go ahead and amend your commit. Use this chance to add to your commit message:
As a side note, our scripts and README.md should ease the job of developers, but do not intend to be exhaustive, or provide solutions to all problems. |
In systems (e.g. Ubuntu 22.04) where python is not aliased as python2 or python3, scripts using python will not find the executable. One way to handle it is to install python-is-python3. However, this may break the system and need great care from the user. The original workaround is similar to the way above, but the copied binary is not managed by the package manager. Another way to fix it is to explicitly use python3 or python2 in the script, which has less impact on the system. This commit introduces a way to fix the building script. Signed-off-by: Hongren Zheng <i@zenithal.me> Reviewed-by: Carlos Bilbao <carlos.bilbao@amd.com>
|
Sorry for the late reply.
Made such changes now, could you please review again? |
|
Looks good to go! :) |
2 participants
There are systems where
/usr/bin/pythonis not avaiable (in my setup, ubuntu 22.04 even though both python2 and python3 are installed). The original workaround may introduce system bugs.By this patch ovmf building process would resort to
python3instead ofpython, thus resolving the problem.