Skip to content

Recommend a new default value of gravity.abs_tol #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maximumcats opened this issue Sep 26, 2017 · 0 comments
Open

Recommend a new default value of gravity.abs_tol #202

maximumcats opened this issue Sep 26, 2017 · 0 comments

Comments

@maximumcats
Copy link
Member

The Poisson solve absolute tolerance sets the accuracy of the Poisson solve. Given the value of abs_tol, the error level targeted in the Poisson solve is abs_tol * 4 * pi * G * rho_max, where rho_max is the maximum density on the domain. For Cartesian simulations the default value is 1.e-11, and for non-Cartesian the default value is 1.e-10.

At high resolution, and/or for complicated mass distributions, this tolerance can be too tight, and the multigrid solve fails. We should study the effect of the gravity tolerance and possibly recommend a new tolerance. If it is justified, the new tolerance should be looser so that the default value fails in fewer cases. However, we should not make it so loose that the effect noticeably deteriorates the accuracy of our simulations.

Issues to study:
(1) Differences between Cartesian and cylindrical/spherical problems
(2) Performance, both for a single processor and for multiple processors
(3) Accuracy -- for a given lower tolerance, how much does the answer change?

These should be studied with a well-used problem like DustCollapse, and also one or two more complicated problems like the Evrard collapse and wdmerger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant