New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please prepare/tag some versioned release ;-) #40
Comments
|
Yes we already two weeks late On our goal of getting this done. On Tuesday, August 13, 2013, Yaroslav Halchenko wrote:
brian |
|
ah -- cool -- what will it be ? (the release version) |
|
Fire ANTs On 8/13/13, Yaroslav Halchenko notifications@github.com wrote:
brian |
|
that is just a suggestion ... i'd be ok with anything except 2.0 or similar On 8/13/13, brian avants stnava@gmail.com wrote:
brian |
|
so 1.99999 ? ;) my current working "version" for it is 1.9.2+svn680+git1417-g48ff309-1 ;-) |
|
btw -- will it be compatible with any released ITK? |
|
ok -- adding |
|
unsure - hans or kent would have to respond to this hans, kent - now seems like as good a time as any to make an ants i was going to follow this procedure: http://gitready.com/beginner/2009/02/03/tagging.html On 8/13/13, Yaroslav Halchenko notifications@github.com wrote:
brian |
|
instructions sound reasonable -- just make sure to create annotated (-a) or signed (-s) tag as they say. lightweight tags (without -a or -s) are another beast |
|
btw to refer to someone -- better to use @HISGITHUBLOGIN, e.g. @Chaircrusher (ken?) so they get notification for sure |
|
BTW if of any value -- here is my build log http://www.onerussian.com/tmp/build.log-2 while having system ITK 4.4.0 |
|
see discussion below On 8/13/13, Yaroslav Halchenko notifications@github.com wrote:
brian |
|
i think including the |
|
Ali Ghayoor has been enhancing ITK to allow for single precision based on a post-4.4.0 version of ITK.Kent Williams norman-k-williams@uiowa.edu On 8/13/13 1:58 PM, "Yaroslav Halchenko" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
Yeah, the exact problem is the new templated transform type.Kent Williams norman-k-williams@uiowa.edu On 8/13/13 2:08 PM, "Yaroslav Halchenko" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
|
Thank you @Chaircrusher |
I don't think so. It's going to end up being pervasive.Kent Williams norman-k-williams@uiowa.edu On 8/14/13 9:15 AM, "Yaroslav Halchenko" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
|
yes - the alternative is to tag an old version that works with 4.4 or wait for 4.5 brian On Wed, Aug 14, 2013 at 10:47 AM, Kent Williams notifications@github.comwrote:
|
|
having a tag for 4.4-compatible version would be nice since then I could update Debian package at least to that state. waiting for 4.5 is quite easy -- I can do that while doing nothing ;) |
|
Hans has an alternate proposal, that I'm trying to implement. The idea is to simply undo the changes Ali introduced to take advantage of I'm testing the build now, but this seems like it will work. I couldn't simply revert Ali's commit as Hans re-organized the I don't know how exactly the 'release' should proceed but I think this
The master branch would incorporate the changes to support single Then, when the next checkpoint release of ITK occurs, ANTs can have a new Kent Williams norman-k-williams@uiowa.edu On 8/14/13 9:58 AM, "Yaroslav Halchenko" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
|
OK so here you go: https://github.com/stnava/ANTs/tree/RevertSinglePrecisionChanges This is a branch off 48ff30 which is the current master revision. It JUST Kent Williams norman-k-williams@uiowa.edu On 8/14/13 9:52 AM, "stnava" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
|
I just modified that branch so it checks out 4.4.0 ITK. It builds and passes tests... https://github.com/stnava/ANTs/tree/RevertSinglePrecisionChanges |
|
Kent, Good work! If this is approved, a release should be tagged on github. Hans From: Kent Williams notifications@github.com I just modified that branch so it checks out 4.4.0 ITK. It builds and https://github.com/stnava/ANTs/tree/RevertSinglePrecisionChanges ‹ |
|
Thank you Kent. I am building/testing on my (slow laptop) end. I will let you know if all good on my end whenever it is done |
|
Brian @stnava , Can you please make the release on github? Thanks, Hans |
|
yes, will do once we hear from yarik. brian On Wed, Aug 14, 2013 at 2:17 PM, hjmjohnson notifications@github.comwrote:
|
|
It should be possible to remove the floating point capabilities of ANTS as a Hans From: Kent Williams notifications@github.com I don't think so. It's going to end up being pervasive.Kent Williams norman-k-williams@uiowa.edu On 8/14/13 9:15 AM, "Yaroslav Halchenko" notifications@github.com wrote:
Notice: This UI Health Care e-mail (including attachments) is covered by the — |
|
Sorry about the delay -- had to restart build on some reasonable box ;) It built successfully. 232 tests (I have built with RUN_SHORT_TESTS on, and for some reason rpath wasn't set to point to library so had to LD_LIBRARY_PATH-adjust) passed. Also you might like to look into all those fuzz-testing "Mayhem" bugs reported on Debian: http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=ants;dist=unstable . current build bin/ANTS simply segfaults if I run it without any cmdline arguments (not kosher!!!! ;) ) For Debian packaging I am yet to decide what to do with ExternalData -- either "package it in" since so far it seems only few megabytes, or provide a separate package for it... also figure out either original datasets it belongs to are copyrighted and under what terms etc... heh heh . Those data files -- are they quite static or change quite often (e.g. between ANTs... ok -- ITK releases)? BTW -- is there somewhere a complete list of what all those MD5'named files on http://www.itk.org/files/ExternalData/ correspond to? did anyone consider placing them under git-annex and linking such a repository for ExternalData as a git submodule? |
|
The external data is stored on http://midas.kitware.com -- then a CMake macro set manages downloading test data on demand. I don't think that for the purposes of the Debian package that you'd need to play any games to support testing, getting test data is part of the build process, and it's done on demand. As far as I know, all the test data is anonmyzed and public domain. I believe Hans implemented most of the MIDAS stuff, maybe he can explain this better. The zero arguments crash is simple enough to fix. I think the problem is in ANTs.cxx -- it doesn't ever check for argc < 2 -- that could be done at the very top of the ANTS function. I see where @stnava has actually commented out some of the sanity checks at the top, maybe he needs to revisit that stuff? |
|
Thank you @Chaircrusher for the clarifications
Debian source package should be self-sufficient and shouldn't get anything from the network upon building binary packages, where I exercise tests to verify correct operation of any given build. You can easily see why it is required to have ALL resources (code and data) available happen you want to guarantee robust building and self-sufficiency of source packages. |
|
perhaps you should turn testing off ... also, it's easy to fix the ANTS bug which has been there so long that we brian On Thu, Aug 15, 2013 at 10:06 AM, Yaroslav Halchenko <
|
|
Yeah build the package without testing. You're not going to be able to ship it with all the test data without completely rewriting the cmake testing code. If someone wants to test ANTs on debian they can build it from source like the rest of us. |
|
i pushed the ANTS bug fix to the RevertSinglePrecisionChanges next step ( if everyone is ready ) git tag -a HoneyPot -m "ANTs based on ITKv4.4, double precision." git push --tags everyone ok with that? brian On Thu, Aug 15, 2013 at 10:16 AM, Kent Williams notifications@github.comwrote:
|
|
so i just went ahead and pushed it up ... now you can do : git tag -n HoneyPot ANTs based on ITKv4.4, double precision. brian On Thu, Aug 15, 2013 at 10:27 AM, brian avants stnava@gmail.com wrote:
|
|
nah guys -- I really want at least some testing at build time. I do want to have some QA that ANTs works correctly across different platforms and releases of core libraries in setups you might not be testing on. I will check later what would be the easiest way to get it working -- test data seems to be not that big. as for the tag @stnava -- I hope there would also be a simple version tag (e.g. 2.0 instead or in-addition to codename HoneyPot tag if I got your comment right)... atm can't even fetch anyways: ok -- got back online, indeed missing versioned tag -- please cook one up as well ;-) |
|
My feeling is that the Debian testing requirements are too restrictive. We have looked at many other options, and reviewed the github options, and Hans From: Yaroslav Halchenko notifications@github.com nah guys -- I really want at least some testing at build time. I do want to as for the tag @stnava https://github.com/stnava -- I hope there would ‹ |
|
how about git tag -a HoneyPot-0.0 ? brian On Thu, Aug 15, 2013 at 12:20 PM, Yaroslav Halchenko <
|
There are no Debian testing requirements. I (personally) prefer and where applicable advocate enabling testing at package build time. When maintaining dozens of projects it is much better/time-efficient/etc to detect/resolve issues before shipping a package out for public use instead of troubleshooting bugs later trying to replicate them etc. There are various additional benefits from it as well (ability to easily do down-stream testing for new releases of core libraries, access to hardware architectures none single other project has available, etc).
Yikes -- I do hope that it is not that rigid as to require rewriting the whole testing framework. Worse comes to worse I might simply "serve" via http the "mirror" of the needed files from http://midas.kitware.com from an ExternalData directory within ANTs tree I would ship within a package ... but I bet there should be a simple solution to get -- I haven't looked yet |
|
Brian, I would like to follow the conventions of the rest of the world if possible? Hans From: stnava notifications@github.com how about git tag -a HoneyPot-0.0 ? brian On Thu, Aug 15, 2013 at 12:20 PM, Yaroslav Halchenko <
‹ |
|
@yarikoptic if you want testing, the only tenable way I can see to do it is to have separate tests with a small set of input data checked in with the source. I'd even guard the existing tests (that download their data from a MIDAS server) so they aren't visible in the Debian package. Even better, if all you care about is the nominal function of the programs, generate some synthetic images at build time and test using them. It simply isn't practical to hack into the MIDAS/ExternalData testing infrastructure. For one thing those are non-trivial CMake modules, that would be a challenge to understand and easy to break. For another, if ANTs diverges too much from the standard CMake infrastructure for testing, it makes maintainence a nightmare. |
|
ok - so HoneyPot-1.0.0 ? or must it be v1.0.0 ? if that is the case then the only choice is v2.0.0 brian On Thu, Aug 15, 2013 at 1:58 PM, hjmjohnson notifications@github.comwrote:
|
|
tangentially related -- why do you have two copies of different versions I guess of this ExternalData.cmake testing? |
|
The one in "BuildScripts/ExternalData.cmake" should be deleted. Hans From: Yaroslav Halchenko notifications@github.com tangentially related -- why do you have two copies of different versions I
$> head BuildScripts/ExternalData.cmake CMake/ExternalData.cmake - Manage data files stored outside source treeUse this module to unambiguously reference data files stored outside thesource tree and fetch them at build time from arbitrary local and remotecontent-addressed locations. Functions provided by this module recognizearguments with the syntax "DATA{}" as references to external data,replace them with full paths to local copies of those data, and createbuild rules to fetch and update the local copies.The DATA{} syntax is literal and the is a full or relative pathwithin the source tree. The source tree must contain either a real data==> CMake/ExternalData.cmake <== - Manage data files stored outside source treeUse this module to unambiguously reference data files stored outside thesource tree and fetch them at build time from arbitrary local and remotecontent-addressed locations. Functions provided by this module recognizearguments with the syntax "DATA{}" as references to external data,replace them with full paths to local copies of those data, and createbuild rules to fetch and update the local copies.The DATA{} syntax is literal and the is a full or relative pathwithin the source tree. The source tree must contain either a real data‹ |
My huge hack for the mighty testing infrastructure will be: while I ship 1 additional tarball associated with the release providing testdata directory with the ExternalData needed for that pack of tests I would like to be ran. That results in ExternalData being "fetched" from file:// location just happily and tests running just fine as well |
|
ok - so we have v2.0.0 and it's called HoneyPot which is indeed a type of so is everyone ( yarik ) happy with this and can this soon be released / brian On Fri, Aug 16, 2013 at 10:38 AM, Yaroslav Halchenko <
|
|
On Sun, 18 Aug 2013, stnava wrote:
I will look into finishing updating packaging/testing it out tomorrow. Cheers,Yaroslav O. Halchenko, Ph.D. |
|
This is a discussion toward 2.0.0 release which did happen and was uploaded to Debian. Thus closing |
Time to update the Debian package but not even sure which point to look at ;)
The text was updated successfully, but these errors were encountered: