Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use loop on package module with squash_actions #14

Merged
merged 5 commits into from Nov 1, 2018

Conversation

@arhue
Copy link

@arhue arhue commented Oct 21, 2018

Fix deprecated warnings with Ansible 2.7

@otakup0pe
Copy link
Member

@otakup0pe otakup0pe commented Oct 23, 2018

Ha I was just making this PR myself. If you can update the min ansible version in meta.yml I'll merge yours instead 💖

Loading

@arhue
Copy link
Author

@arhue arhue commented Oct 24, 2018

@otakup0pe Done!

Loading

@otakup0pe
Copy link
Member

@otakup0pe otakup0pe commented Oct 24, 2018

Hmm reading https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html I thought that this syntax wasn't supported until 2.7 ? If it's 2.3 that'll make this transition easier for a lot of people.

Loading

@otakup0pe
Copy link
Member

@otakup0pe otakup0pe commented Oct 24, 2018

Oh now that I read the docs again it's more clear. Cool! Can you update https://github.com/ANXS/build-essential/blob/862bd39f59e967028bdba6bc1d2c356c3b512b5d/.travis.yml to test against 2.3 and 2.7? Forgot about this yesterday 👀

Loading

@arhue
Copy link
Author

@arhue arhue commented Oct 24, 2018

@otakup0pe See if it looks ok now. Should I remove 1.9 and 2.0 as versions to test against? I've just added 2.3 and 2.7 to that list without removing anything.

Loading

@otakup0pe
Copy link
Member

@otakup0pe otakup0pe commented Oct 24, 2018

Since we only support 2.3 and above, that's all we should test against. Interesting that the tests pass but then again we aren't really validating that the changes are what we want.

Loading

@arhue
Copy link
Author

@arhue arhue commented Oct 24, 2018

@otakup0pe Change made as suggested.

Loading

@otakup0pe otakup0pe merged commit dc9b708 into ANXS:master Nov 1, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants