Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges user privilages into correct role #62

Merged
merged 3 commits into from Jan 30, 2015
Merged

Merges user privilages into correct role #62

merged 3 commits into from Jan 30, 2015

Conversation

@leonelgalan
Copy link
Contributor

@leonelgalan leonelgalan commented Jan 28, 2015

Somehow user privileges where being changed on tasks/users.yml, before the databases where created causing errors. I moved all user privileges to tasks/users_privileges.yml merging the options that where there.

This bug is affecting master after yesterday's merges.

@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Jan 28, 2015

I just notice that Travis build successfully because no users, db, or privileges are created/edited while testing. Should I change that too?

leonelgalan added 2 commits Jan 29, 2015
This allows these "three" tasks files to be tested.
All variables inside the playbook's `vars:` where
being overwritten by those on `defaults/main.yml`
@ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jan 30, 2015

@leonelgalan, facing the same issue here running the role against a scratch environment. I'm not a maintainer, but testing this play is (clearly) necessary, thanks a lot for patching it in!

pjan added a commit that referenced this pull request Jan 30, 2015
Merges user privilages into correct role
@pjan pjan merged commit 792f943 into ANXS:master Jan 30, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@pjan
Copy link
Contributor

@pjan pjan commented Jan 30, 2015

Thanks @leonelgalan, and so sorry for the break. The backlog with PRs was rather big before this week, and I really have to squeeze to get maintenance time for all the ANXS roles in (candidate co-maintainers are very welcome).

Anyway, thank you for patching it, it's greatly appreciated.

Have a great weekend.

@ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jan 30, 2015

@pjan, thanks for the near-instant response, enjoy the weekend!

@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Jan 30, 2015

@pjan I'm happy to help, let me explore the rest of ANXS roles, I've only use a couple.

@leetrout
Copy link
Contributor

@leetrout leetrout commented Jan 30, 2015

My bad- it was passing on my machine because I had already created the db and wasn't running the playbook fresh. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants