Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ProcessFile.srv to include topic_name field. #198

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

marco-tranzatto
Copy link
Contributor

Functions saveToBag and loadFromBag from "GridMapRosConverter.hpp" require an absolute path of the rosbg and a topic name.
Service 'ProcessFile.srv' is extended to allow the specification of a topic name.

@pfankhauser
Copy link
Member

What do you think about my change proposal?

@marco-tranzatto
Copy link
Contributor Author

@pfankhauser I actually prefer only one field, because I think it's easier to handle and in any case in each rosbag you want to process only one topic per service call. I believe that if you start adding the possibilities of processing multiple topics with one service call, then the user should be aware of the order of the topic names. For example topic_name#1 is used for XX whereas topic#2 is used for YY and so on. I think this complicates things, and we should aim at having different names of service calls, one for each topic we want to process. Therefore I'd have only one string instead of the array.

Do you see any practical example where you want multiple topic names?

@marco-tranzatto
Copy link
Contributor Author

single topic_name field restored, as agreed with @pfankhauser

@pfankhauser pfankhauser merged commit c1b2dd9 into master Jan 29, 2019
@pfankhauser pfankhauser deleted the feature/extend_process_file_srv branch January 29, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants