Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

exynos: Apply format usage flag hack to YUV420P

This is needed for planar format video in
addition to semiplanar.  Also, update the flag
to be more representative of what it REALLY does,
which is merely to add GRALLOC_USAGE_HW_FIMC1.

This fixes Netflix on Note 10.1 so it no
longer needs Developer Options hacks.

Change-Id: I31df87c252779e66a056b79b1f48779024ec0f30
  • Loading branch information...
commit 68810ee26594bd7a80e3e6419258904de44b0545 1 parent f5acb39
Andrew Dodd Entropy512 authored PierPP committed

Showing 1 changed file with 3 additions and 5 deletions. Show diff stats Hide diff stats

  1. +3 5 libs/ui/GraphicBufferAllocator.cpp
8 libs/ui/GraphicBufferAllocator.cpp
@@ -114,12 +114,10 @@ status_t GraphicBufferAllocator::alloc(uint32_t w, uint32_t h,
114 114 status_t err;
115 115
116 116 #ifdef EXYNOS4_ENHANCEMENTS
117   - if (format == 0x105) {
  117 + if ((format == 0x101) || (format == 0x105)) {
  118 + // 0x101 = HAL_PIXEL_FORMAT_YCbCr_420_P (Samsung-specific pixel format)
118 119 // 0x105 = HAL_PIXEL_FORMAT_YCbCr_420_SP (Samsung-specific pixel format)
119   - usage = GRALLOC_USAGE_HW_FIMC1; // Samsung specific flag for video rendering
120   - usage |= GRALLOC_USAGE_EXTERNAL_DISP;
121   - usage |= GRALLOC_USAGE_HW_COMPOSER;
122   - usage |= GRALLOC_USAGE_HW_TEXTURE;
  120 + usage |= GRALLOC_USAGE_HW_FIMC1; // Exynos HWC wants FIMC-friendly memory allocation
123 121 }
124 122 #endif
125 123

Git Notes

review

Code-Review+1: Pierpaolo Pernici (pier) <pierpaolo@gmail.com>
Code-Review+2: Chris Yeninas <projectsundergaming@gmail.com>
Verified+1: Chris Yeninas <projectsundergaming@gmail.com>
Submitted-by: Chris Yeninas <projectsundergaming@gmail.com>
Submitted-at: Thu, 27 Sep 2012 00:10:42 +0100
Reviewed-on: http://gerrit.sudoservers.com/3669
Project: AOKP/frameworks_native
Branch: refs/heads/jb

0 comments on commit 68810ee

Please sign in to comment.
Something went wrong with that request. Please try again.