Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Using SystemVibrator in the cases other than Ringer.java
In ICS, Phone app was creating separate Vibrator instances in Ringer.java and CallNotifier.java, while in Jellybean they started relying on one single Vibrator Service. See also Id928ffef9a87e2563198240e91184cf59ecebbb1. It means vibrate()/cancel() calls from two files interfere with each other. When "Emergency tone" is set to "Vibrate" in Sound Setting (which is only available with CDMA devices), this causes unexpected trouble; the "Emergency tone" vibration is canceled immediately by Ringer's Vibrator#cancel() call. onPhoneStateChanged() is indirectly calling the method. This change stops using the Vibrator Service in the emergency vibration case, so that two Vibrator objects won't interfere with each other. TESTED (use CDMA phone): - Set "Emergency tone" to "Vibrate", and make a phone call to "911" -> The device should vibrate for hundreds of mills (even without a fix, it may vibrate for an instant, so need to check how long) Bug: 6794250 Change-Id: I69e6c3d99b14b3c50c57ff5d59ca42f4ea18024f
- Loading branch information
Daisuke Miyakawa
committed
Jul 12, 2012
1 parent
04642a3
commit 12c60e4
Showing
3 changed files
with
14 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters