New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict the min_tile_width if "in-loop-filtering" is enable #59

Closed
totang opened this Issue Mar 30, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@totang

totang commented Mar 30, 2018

This can help alleviating memory latency issue in case load/store some top buffers into external memory .
The min_tile_width can be 256 pixels if "in-loop-filtering " is enable .
otherwise min_tile_width can equal to SB size .

@peterderivaz

This comment has been minimized.

Collaborator

peterderivaz commented Mar 31, 2018

Is this a feature request that would result in changes to the reference code?

If you want to make a feature request that affects the code, you should post to the aomedia issue tracker:
https://bugs.chromium.org/p/aomedia/issues/list

@totang

This comment has been minimized.

totang commented Mar 31, 2018

No,just add restriction in specification .

@peterderivaz

This comment has been minimized.

Collaborator

peterderivaz commented Apr 1, 2018

Restrictions in the specification should correspond to parts of the code that trigger errors/warning messages. Can you point out the bit of the code that would result in an error if such a stream was played?

If such an error condition does not currently exist in the code, then the process for adding a new restriction is:

  1. Raise issue on the aomedia issue tracker (link above)
  2. If agreed, submit code patch to generate an error on streams that fail the spec
  3. Then update the spec to match the code

This spec is just based on reverse engineering the reference code - just changing the spec by itself has no meaning unless accompanied by changes to the reference code (or an official accepted design document).

@peterderivaz

This comment has been minimized.

Collaborator

peterderivaz commented Apr 3, 2018

Issue moved to aom issue tracker:

@peterderivaz

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment