Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.18 Survey #3923

Merged
merged 120 commits into from
Jul 8, 2022
Merged

Go 1.18 Survey #3923

merged 120 commits into from
Jul 8, 2022

Conversation

CamberLoid
Copy link
Member

@CamberLoid CamberLoid commented Apr 12, 2022 •
edited

Topic Description

This topic will update go to 1.18 1.18.1. Check updates and rebuild all packages of groups/go-rebuilds.

Package(s) Affected

go
groups/go-rebuilds
extra-base/golang-base

And others
scons flatbuffers

cmdline: ciel clean;ciel build -i {$instance} go go-md2man groups/go-rebuilds

Security Update?

No.

Build Order

  1. scons Noarch dependency. build and push first;
  2. go The compiler itself;
  3. golang-base go-md2man Toolkits for go;
  4. groups/go-rebuilds All other packages;
  5. flatbuffers Non-go-based package.

Test Build(s) Done

The checklist: #3923 (comment)

Primary Architectures

  • AMD64 amd64
  • AArch64 arm64

Secondary Architectures

Architectural progress for "secondary," or experimental ports does not impede on merging of this topic.

  • Loongson 3 loongson3
  • PowerPC 64-bit (Little Endian) ppc64el
  • RISC-V 64-bit riscv64

Update(s) Uploaded to Stable

Primary Architectures

  • AMD64 amd64
  • AArch64 arm64

Secondary Architectures

Architectural progress for "secondary," or experimental ports does not impede on merging of this topic.

  • Loongson 3 loongson3
  • PowerPC 64-bit (Little Endian) ppc64el
  • RISC-V 64-bit riscv64

@CamberLoid CamberLoid marked this pull request as draft April 12, 2022 02:43
@CamberLoid CamberLoid added survey Topic is a survey of a set or category of packages long-term Topic/issue to be addressed over the long-term upgrade Topic/issue involves a package upgrade labels Apr 13, 2022
@CamberLoid
Copy link
Member Author

Upstream has released newer go compiler 1.18.1 . Previously updated packages will be rebuilt.

@CamberLoid
Copy link
Member Author

popub is tested and perform well on riscv64.
Despite there is no major behavior change between two commit of upstream, this package may require further tests due to the change of compiler from gccgo to google-go

@CamberLoid

This comment was marked as resolved.

Sign in to view
@CamberLoid

This comment was marked as resolved.

Sign in to view
@CamberLoid CamberLoid force-pushed the go-1.18-survey-20220401 branch 3 times, most recently from d4a8ac1 to e9b259a Compare May 8, 2022 08:26
@CamberLoid
Copy link
Member Author

CamberLoid commented May 8, 2022 •
edited

Test checklist for packages, so far

  1. Core component
  • The compiler itself go | As long as there is no building error for other packages, considering this is tested
  1. Packages to upgrade
  1. Packages to rebuild
  • libguestfs: Too complex. Will not upgrade in this topic (or after all other main upgrade complete)
  • v2ray-plugins | Functionality tests are required because this update switches build method to ABTYPE
  • obfs4proxy
  • dep
  • glide
  • podman | Upgrade of which may be proceeded in next OCI/container survey;

@CamberLoid

This comment was marked as resolved.

Sign in to view
@CamberLoid CamberLoid mentioned this pull request May 9, 2022
Open
@CamberLoid
Copy link
Member Author

CamberLoid commented May 9, 2022 •
edited

Patches in commit 0a71c63 and ca7dfe9 have been formed into a pull request and submitted to upstream. This patch will solve a FTBFS issue on riscv64 platform.

Reference:

@CamberLoid
Copy link
Member Author

Tests for clash(FOSS) are skipped because a checking dependency docker is missing, which is required by upstream-shipped test suite.

@CamberLoid

This comment was marked as resolved.

Sign in to view
@CamberLoid

This comment was marked as resolved.

Sign in to view
@CamberLoid
Copy link
Member Author

Unit tests for flatbuffers are skipped as built-in tests are broken (also reported by archlinux).

@CamberLoid
Copy link
Member Author

CamberLoid commented May 11, 2022 •
edited

flatbuffers does not require go and openjdk to build. Will be dropped out of groups/go-rebuilds by the end of survey.

MingcongBai
MingcongBai requested changes May 11, 2022
View reviewed changes
extra-shells/elvish/autobuild/postinst Outdated Show resolved Hide resolved
extra-shells/elvish/autobuild/postrm Outdated Show resolved Hide resolved
extra-shells/elvish/autobuild/postrm Outdated Show resolved Hide resolved
extra-shells/elvish/autobuild/prepare Show resolved Hide resolved
extra-shells/elvish/autobuild/build Outdated Show resolved Hide resolved
extra-shells/elvish/autobuild/build Show resolved Hide resolved
extra-shells/elvish/autobuild/build Outdated Show resolved Hide resolved
@CamberLoid CamberLoid force-pushed the go-1.18-survey-20220401 branch 3 times, most recently from b1c5851 to 3ad202c Compare May 12, 2022 03:59
@CamberLoid
Copy link
Member Author

Test build for arm64 is successfully performed

@CamberLoid CamberLoid mentioned this pull request May 13, 2022
Merged
@CamberLoid
Copy link
Member Author

CamberLoid commented May 17, 2022 •
edited

Tests for gogs is successfully performed on the following platforms: gogs web + lynx localhost:3000

  • amd64
    image
  • arm64
    image
  • loongson3
  • riscv64

@OriginCode
Copy link
Member

image

@CamberLoid
dnscrypt: fix missing slash in build script
81b70b6
@CamberLoid
dnscrypt: conffile: strip empty lines
6b26af6
@CamberLoid
graftcp: fix FTBFS by backporting
e3ac138 
- Also update systemd unit file to follow upstream's configuration
@CamberLoid
keybase: refine build script to solve a FTBFS problem;
4373d99 
Strip unneeded dependency
@CamberLoid
gost: mark FAIL_ARCH="riscv64" due depending ...
2600d3e 
go module error.
@CamberLoid
gogs: update patches to latest upstream version(AUR)
3fceae1
@CamberLoid
rclone: remove deprecated funtion call
76a3d17
@CamberLoid
kcptun: fix a FTBFS caused by outdated dependency
9746c96
@CamberLoid
kcptun: minor expression refine and enable update of dependencies
a1bfd86
@CamberLoid
v2ray-plugin: fix a FTBFS caused by outdated dependency
b0c6902
@CamberLoid
gogs: minor refinement of dependency list
efe7394
@CamberLoid
hugo: fix file belonging issue.
8b065f8
@CamberLoid
elvish: add FIXME reminder to rollback REL
32fb8e9
@CamberLoid
direnv: drop pre-build GOFLAGS setting
505206b
@CamberLoid
gh: strip pre-build setting of GOFLAGS
67e5bc3 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid
rclone: strip redundant GOFLAGS
a6d7742 
Signed-off-by: Camber Huang <camber@poi.science>
MingcongBai
MingcongBai previously approved these changes Jul 6, 2022
View reviewed changes
@CamberLoid
hugo: rebuild for go 1.18.1; bump rel; resolve confilcts.
c08cad1
@CamberLoid
gotop: revert REL bump
1b57229 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid
dep: revert REL bump
d994c5e 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid
glide: revert REL bump
6543b28 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid
elvish: revert REL bumping
ba39f46 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid
golang-base: fix dependency on non ARM64/AMD64 platform
328464f 
Signed-off-by: Camber Huang <camber@poi.science>
@CamberLoid CamberLoid merged commit fd3e5db into stable Jul 8, 2022
@CamberLoid CamberLoid deleted the go-1.18-survey-20220401 branch July 8, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MingcongBai MingcongBai MingcongBai approved these changes

Assignees
No one assigned
Labels
long-term Topic/issue to be addressed over the long-term survey Topic is a survey of a set or category of packages upgrade Topic/issue involves a package upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CamberLoid @OriginCode @MingcongBai