Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace icon in readme has a low resolution on HiDPI #96

Closed
ingomohr opened this issue Jun 28, 2020 · 8 comments
Closed

Marketplace icon in readme has a low resolution on HiDPI #96

ingomohr opened this issue Jun 28, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers upstream This issue originates upstream (in Eclipse IDE itself)
Milestone
2.0

Comments

@ingomohr
Copy link
Contributor

Screenshot 2020-06-28 at 11 34 03

The screenshot is taken on a retina display (Macbook Pro). The effect should be the same on a 4k display as well.
Compared to the other icons, the Marketplace icon has a pretty low resolution and looks a bit misplaced.

Maybe, there's a HiDPI icon for that, too? (Didn't check, though)
@AObuchow
Copy link
Owner

Thanks for pointing this out as I was unaware it was so low res. The icon was copy pasted from the “external link” section of the marketplace listing.

I’m not sure if a HiDPI version of the icon exists but maybe a bug should be made in marketplace?

@AObuchow AObuchow added documentation Improvements or additions to documentation needs upstream bug labels Jun 28, 2020
@PyvesB
Copy link
Contributor

PyvesB commented Jul 18, 2020

I did not find any open bugs, so I opened a new one here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=565317

@AObuchow AObuchow added upstream This issue originates upstream (in Eclipse IDE itself) and removed needs upstream bug labels Jul 18, 2020
@AObuchow
Copy link
Owner

Looks like the upstream bug has been resolved (I noticed @PyvesB 's PyvesB/eclipse-planet-themes@1c169b6 :) )

@PyvesB
Copy link
Contributor

PyvesB commented Aug 15, 2020

Indeed! Though I had to slightly tweak the default HTML provided by the marketplace, as width was not being properly set. 😉

@AObuchow
Copy link
Owner

@PyvesB thanks for the note ;) and thanks for reporting the upstream bug :D

@AObuchow
Copy link
Owner

@ingomohr if you're interested, feel free to take this one on btw :)

@AObuchow AObuchow added the good first issue Good for newcomers label Sep 7, 2020
@AObuchow AObuchow added this to the 2.0 milestone Sep 8, 2020
@ingomohr ingomohr mentioned this issue Oct 29, 2020
Merged
@ingomohr
Copy link
Contributor Author

Hi there 😄 - I can't link PRs, but it's #138.

@AObuchow
Copy link
Owner

Hi there smile - I can't link PRs, but it's #138.

Fixed via d14a747 thanks @ingomohr :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers upstream This issue originates upstream (in Eclipse IDE itself)
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@ingomohr @AObuchow @PyvesB