Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github spec validation & response headers #21

Merged
merged 3 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

pimterry commented Feb 14, 2019

This PR:

  • Combines the equivalent /teams/{teamId}/repos/{org}/{repo} and /teams/{teamId}/repos/{owner}/{repo} paths into one (there's no overlap in operations), so that the spec validates (according to https://editor.swagger.io/)

  • Moves X-GitHub-Media-Type, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset and X-GitHub-Request-Id from the request to the response (where they belong). This fixes APIs-guru/openapi-directory#187.

It's an enormous PR, sorry! I've separated the changes by commit, so you can see the 1st change independently. The 2nd change is automated, it's just a huge regex replace to drop those headers from every request, and then insert them into every response.

@pimterry pimterry force-pushed the httptoolkit:github-fixup branch from ff32500 to 64d8344 Feb 14, 2019

@MikeRalphson

This comment has been minimized.

Copy link
Collaborator

MikeRalphson commented Feb 16, 2019

@pimterry thanks! I've fixed the twitter API definition issue, but that still seems to leave us with a github validation error. Could you take a look?

@pimterry

This comment has been minimized.

Copy link
Contributor Author

pimterry commented Feb 18, 2019

@MikeRalphson I've fixed up the github header format, and it all seems happy now 👍

@MikeRalphson MikeRalphson merged commit 11d1038 into APIs-guru:master Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeRalphson

This comment has been minimized.

Copy link
Collaborator

MikeRalphson commented Feb 18, 2019

Update deployed ok, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.