Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly include the default Twilio mediaTypeExtension #23

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

pimterry commented Feb 22, 2019

This parameter is marked required, which isn't really correct - it's entirely optional, and defaults to XML.

Unfortunately this parameter must be marked required anyway because it's a path parameter, which is a bit awkward. This change marks that extension as the default, which at least makes clearer imo - it's required that somebody provides this, but the API will do it for you if you don't.

This one is a little debatable. It's a valid spec though, and it is very convenient for my case to be able to say "this param is required and wasn't unspecified, but it's ok because it's defaulted to X anyway"

Actual change looks long, but it's really a single trivial find & replace.

@pimterry

This comment has been minimized.

Copy link
Contributor Author

pimterry commented Feb 28, 2019

Hi @MikeRalphson, any thoughts on this one? No urgent hurry, just checking it hasn't been missed.

@MikeRalphson MikeRalphson merged commit 72dd50f into APIs-guru:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeRalphson

This comment has been minimized.

Copy link
Collaborator

MikeRalphson commented Mar 4, 2019

Apologies, yes, I forgot about this after seeing the initial notification. Will update the main directory shortly.

@pimterry

This comment has been minimized.

Copy link
Contributor Author

pimterry commented Mar 4, 2019

Awesome, thanks!

@pimterry pimterry deleted the httptoolkit:twilio-extension branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.