Lots of editorial fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkumari
approved these changes
Feb 28, 2018
Thank you very much - these improve the document, and sending it as a PR is much appreciated.
| @@ -492,7 +497,7 @@ | |||
| Sivaraman, Petr Spacek. Andrew Sullivan, Paul Vixie, Duane Wessels and | |||
| Paul Wouters for their helpful feedback.</t> | |||
|
|
|||
| <t>[TODO: Add people who have contributed!]</t> | |||
| <t>[TODO: Add more people who have contributed!]</t> | |||
| The "kskroll-sentinel-not-ta-<tag-index>" label is used in | ||
| a query where the response can answer whether this the key tag | ||
| of a trust anchor that is NOT in currently trusting.</t> | ||
|
|
There was a problem hiding this comment.
The last sentence / phrase is hard to parse (" that is NOT in currently trusting."); I'll patch it later, no need up update PR.
wkumari
added a commit
that referenced
this issue
Feb 28, 2018
Integrated / published comments from Paul in GitHub PR #2 - #2 Made the keytab be decimal, not hex (thread / consensus in https://mailarchive.ietf.org/arch/msg/dnsop/Kg7AtDhFRNw31He8n0_bMr9hBuE )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.