Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

这个拉取是为了解决丁驰在issue中提到的使用sur_Residual作为容器来组装边界积分的提议 #159

Merged
merged 3 commits into from
Jul 30, 2024
Merged

这个拉取是为了解决丁驰在issue中提到的使用sur_Residual作为容器来组装边界积分的提议 #159

merged 3 commits into from
Jul 30, 2024

Conversation

ju-liu
Copy link
Contributor

@ju-liu ju-liu commented Jul 20, 2024

提高程序的逻辑一致性：使用sur_Residual作为容器来处理边界积分。

@ju-liu ju-liu self-assigned this Jul 20, 2024
@ju-liu ju-liu requested a review from Mr-Chi-Ding July 20, 2024 02:05
@ju-liu
Copy link
Contributor Author

ju-liu commented Jul 20, 2024

@Mr-Chi-Ding 请review这个改动，然后对于examples/ruc_fsi项目中的同样的地方作同样的改动。
ns 和 ruc 都修改完成后 我再次review完 再merge。

@ju-liu ju-liu linked an issue Jul 20, 2024 that may be closed by this pull request
EBC functions from PLocaAssem in ns need to be updated. #141
Closed
Mr-Chi-Ding
Mr-Chi-Ding approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@Mr-Chi-Ding Mr-Chi-Ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已验证，改动前后运行结果相同。

@ju-liu
Copy link
Contributor Author

ju-liu commented Jul 27, 2024

已验证，改动前后运行结果相同。

用valgrind跑，看是否有内存问题。具体可以咨询黄宣铭。 @Mr-Chi-Ding

@Mr-Chi-Ding
Copy link
Contributor

Mr-Chi-Ding commented Jul 29, 2024 •
edited
Loading

无内存泄漏。

==26878==
==26878== HEAP SUMMARY:
==26878== in use at exit: 0 bytes in 0 blocks
==26878== total heap usage: 2,424 allocs, 2,424 frees, 2,426,388 bytes allocated
==26878==
==26878== All heap blocks were freed -- no leaks are possible
==26878==
==26878== For lists of detected and suppressed errors, rerun with: -s
==26878== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Uploading memory.png…

@ju-liu ju-liu merged commit 901614a into sun-dev Jul 30, 2024
@ju-liu ju-liu deleted the bugfix/localassembly-style branch July 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Chi-Ding Mr-Chi-Ding Mr-Chi-Ding approved these changes

Assignees

@ju-liu ju-liu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EBC functions from PLocaAssem in ns need to be updated.
2 participants
@ju-liu @Mr-Chi-Ding