Skip to content

Conversation

@mat2maa
Copy link
Contributor

@mat2maa mat2maa commented Jun 10, 2016

Tested with RN 0.26.2.

@alvaromb
Copy link
Collaborator

👍 will merge today!

Thanks @mat2maa!

@alvaromb
Copy link
Collaborator

alvaromb commented Jun 13, 2016

Can you separate the following commits and make another PR?

I don't want to merge the RN>=25 support with the other changes.

@mat2maa
Copy link
Contributor Author

mat2maa commented Jun 13, 2016

Apologies, I thought you had already merged. I've split of my changes into a separate repo and force pushed a reset back to the relevant commit on this fork.

@alvaromb
Copy link
Collaborator

Sorry @mat2maa 😢

I didn't have time to do it on Friday, apologies.

@mat2maa
Copy link
Contributor Author

mat2maa commented Jun 13, 2016

😄 No worries @alvaromb, thanks for the useful component!

@alvaromb alvaromb merged commit 1fec8ce into APSL:master Jun 14, 2016
@alvaromb
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants