New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_handleRef: support for Animated wrappers #274

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@slorber
Collaborator

slorber commented Jul 2, 2018

Currently the ref provided by Animated.ScrollView is a wrapper, on which we can call "getNode()"

The current change ensure that we unwrap the real scrollview before trying to use the scrollview methods, and keep retrocompatibility for non-animated scrollviews

See also facebook/react-native#19650

_handleRef: support for Animated wrappers
Currently the ref provided by Animated.ScrollView is a wrapper, on which we can call "getNode()"

The current change ensure that we unwrap the real scrollview before trying to use the scrollview methods, and keep retrocompatibility for non-animated scrollviews

See also facebook/react-native#19650
@alvaromb

This comment has been minimized.

Member

alvaromb commented Jul 12, 2018

LGTM

@alvaromb alvaromb merged commit ea13c8c into APSL:master Jul 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment