New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HOC options API #288

Merged
merged 2 commits into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@slorber
Collaborator

slorber commented Jul 31, 2018

@alvaromb it's a work in progress, not to merge yet

if you have any opinion on this tell me please

@slorber slorber requested a review from alvaromb Aug 1, 2018

@slorber

This comment has been minimized.

Collaborator

slorber commented Aug 1, 2018

hey @alvaromb , my code seems to work fine in my app

I am not able to merge my PR, not to push directly on master

@slorber

This comment has been minimized.

Collaborator

slorber commented Aug 3, 2018

@alvaromb can you give me the rights to merge and publish? Or approve the PR?

@alvaromb

This comment has been minimized.

Member

alvaromb commented Aug 6, 2018

Sorry @slorber, please try again

@slorber

This comment has been minimized.

Collaborator

slorber commented Aug 6, 2018

thanks, this seems to be working now. I'll make a release with notes soon

@slorber slorber merged commit 98f4912 into APSL:master Aug 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment