Skip to content

🐛 [pagination] Fix stream pagination #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acabarbaye merged 2 commits into from
Nov 15, 2024
Merged

🐛 [pagination] Fix stream pagination #518

acabarbaye merged 2 commits into from
Nov 15, 2024

Conversation

@acabarbaye
Copy link
Contributor

@acabarbaye acabarbaye commented Nov 15, 2024 •
edited
Loading

Description

  • Streams implementation had some bugs in that the browsing would stop before reaching the end.
  • Added a lot more specific stream tests

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@acabarbaye acabarbaye merged commit 37c3a62 into master Nov 15, 2024
6 checks passed
@acabarbaye acabarbaye deleted the pagination-fix branch November 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acabarbaye