Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query on license header #685

Closed
sandeepbrcm opened this issue Mar 14, 2019 · 3 comments
Closed

query on license header #685

sandeepbrcm opened this issue Mar 14, 2019 · 3 comments
Labels

Comments

@sandeepbrcm
Copy link

sandeepbrcm commented Mar 14, 2019

I have a generic query on BSD-3. Please advise. Even though its not much TF-A specific,
there are code from plat/arm which fits with/without modification to other SoC platforms.
Some implementation have replicated and renamed files/functions and some platforms may have a different or slightly resembling implementation. I understand if it is completely reusable we must raise pull request to move it to driver or plat/common . eg: scmi scpi protocol implementation, some of the standard IP drivers etc.

In order to add a platform support the code reused ( a copy in plat/xxx) from plat/arm reference should
have which header if there are considerable additions/modifications to the original file/functions.
Only:
Copyright (c) 2018, ARM Limited and Contributors. All rights reserved
Or
Copyright (c) 2018, . All rights reserved
Or can it also have both.
Copyright (c) 2018, ARM Limited and Contributors. All rights reserved
Copyright (c) 2018, . All rights reserved
I see most plat/xxx implementation maintains header as
Copyright (c) 2018, ARM Limited and Contributors. All rights reserved
Or it depends on what exactly the file looks like.
Thanks.

@robertovargas-arm
Copy link

After the 2.o release the policy about copyrights was changed. Before 2.0, all the files had "ARM Limited and Contributors. All rights reserved", but after it, significant modifications can incorporate Copyrights from companies different than ARM. Lines like:

  Copyright (c) 2018, . All rights reserved

seem wrong to me, because the copyright holder is lost, and it means that the copyright line has no meaning.

@sandeepbrcm
Copy link
Author

Thanks . I omitted the name. I meant Copyright (c) 2018, contributor-name. All rights reserved.
But I understood that part. I understand that in case of significant contribution one can
add own copyright. I am specifically confused with the files that are inspired / replicated from
plat/arm to plat/xxx eg: arm_bl2_setup.c.

Or in some cases is it even valid to have ..
Copyright (c) 2018, ARM Limited and Contributors. All rights reserved
Copyright (c) 2018, other-contributor-name. All rights reserved

@soby-mathew
Copy link

Yes, it is valid to have multiple copyright licenses in a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants