Skip to content

i2ceeprom - use mbed_official fork #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2017
Merged

i2ceeprom - use mbed_official fork #38

merged 1 commit into from
Mar 14, 2017

Conversation

@0xc0170
Copy link
Collaborator

@0xc0170 0xc0170 commented Mar 8, 2017 •
edited
Loading

To be able to fix/develop this fork.

Tested with k64f (using latest mbed-os master):

+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target       | platform_name | test suite    | test case                          | passed | failed | result | elapsed_time (sec) |
+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 10  Bytes     | 1      | 0      | OK     | 0.07               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 100 Bytes     | 1      | 0      | OK     | 0.08               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 2 Bytes       | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR Single Byte   | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 10  Bytes         | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 100 Bytes         | 1      | 0      | OK     | 0.08               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 2 Bytes           | 1      | 0      | OK     | 0.05               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR Single Byte       | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  Instantiation of I2C Object | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  LM75B Temperature Read      | 1      | 0      | OK     | 0.06               |
+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

As the current one is not anymore in the development (PR ignored for some time).

cc @BlackstoneEngineering

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 8, 2017

cc @LMESTM

@LMESTM
Copy link
Contributor

LMESTM commented Mar 8, 2017

@0xc0170 thanks
I'd like to test it but I'm not so good at hg usage, so if I cherry-pick this git commit ,
what are the next hg commands that I should use to get the up-to-date I2C library ?

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 8, 2017

just fetch my branch or use this lib (the link updated). do mbed update and it should fetch that i2c library to test.. Please read my comment about your pull request. I did not get full details how it fixes a problem (what problem it has).

@LMESTM
Copy link
Contributor

LMESTM commented Mar 8, 2017

@0xc0170 thanks - so let's mbed update :-)
I actually answered your comment about the pull request yesterday

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 8, 2017

I actually answered your comment about the pull request yesterday

Thanks, accepted. This PR should get an update then use the latest version (I'll retest it again).

This should be the new version: https://developer.mbed.org/users/mbed_official/code/I2CEeprom/rev/973c4289c44c

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 8, 2017

Done, rebased. It now includes the latest version.

Retested, mbed-os latest master, k64f, GCC_ARM:

+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target       | platform_name | test suite    | test case                          | passed | failed | result | elapsed_time (sec) |
+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 10  Bytes     | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 100 Bytes     | 1      | 0      | OK     | 0.08               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR 2 Bytes       | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm 2nd WR Single Byte   | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 10  Bytes         | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 100 Bytes         | 1      | 0      | OK     | 0.08               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR 2 Bytes           | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  EEProm WR Single Byte       | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  Instantiation of I2C Object | 1      | 0      | OK     | 0.06               |
| K64F-GCC_ARM | K64F          | tests-api-i2c | I2C -  LM75B Temperature Read      | 1      | 0      | OK     | 0.06               |
+--------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

@LMESTM Please retest !

@LMESTM
Copy link
Contributor

LMESTM commented Mar 8, 2017

@0xc0170 Works ok here.
Although I don't see where your "2nd WR" tests come from.

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.33 |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.72 |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.29 |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.17 |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.06 |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.13 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.33 |
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.72 |
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.29 |
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.18 |
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.08 |
| NUCLEO_F401RE-ARM | NUCLEO_F401RE | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.12 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 9, 2017

@BlackstoneEngineering +1 ?

@BlackstoneEngineering
Copy link
Contributor

BlackstoneEngineering commented Mar 9, 2017 •
edited
Loading

@0xc0170 if I understand it correctly you forked the library, fixed the issue, and updated the latest master branch of CI Test shiled to use it correct? Assuming this works then I am perfectly happy with this!

Please make sure to test on at least 3 different vendor boards, so a K64F, a ST429, and a OnSemi or a Neuvoton or similar

@0xc0170
Copy link
Collaborator Author

0xc0170 commented Mar 14, 2017

Tested with nuvoton also, all OK.

@0xc0170 0xc0170 merged commit 765b55e into ARMmbed:master Mar 14, 2017
@0xc0170 0xc0170 deleted the fix_i2ceeprom branch March 14, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xc0170 @LMESTM @BlackstoneEngineering