Seperated TESTS/API/PWM into three seperate tests. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Adds the features requested here: #58 |
Contributor
|
@brandonboesch please make sure you remove the binary files form this PR. |
brandonboesch
force-pushed
the
pwm-seperation
branch
from
e4fd94a to
5da9def
Compare
Contributor
Author
|
@BlackstoneEngineering , the binary file has been removed. Good catch! |
Contributor
|
@khj098765 Awaiting feedback from you to see if this satisfies the requirement for the wiznet boards |
Contributor
|
@andrewc-arm , can you please test this on wiznet hardware so we can proceed. |
|
@mray19027 @BlackstoneEngineering @andrewc-arm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having only a single pwm test which measures interrupts on both rise and fall triggers, we now have it seperated as follows:
TESTS/API/PWM_rise - Tests with only rising triggers at a set period and set duty cycle
TESTS/API/PWM_fall - Tests with only falling triggers at a set period and set duty cycle
TESTS/API/PWM_rise_fall - Tests with both rising and falling triggers at multiple periods and duty cycles