Skip to content

Add NUCLEO_L433RC_P and NUCLEO_F722ZE boards #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theotherjimmy merged 1 commit into from
Oct 6, 2017
Merged

Add NUCLEO_L433RC_P and NUCLEO_F722ZE boards #223

theotherjimmy merged 1 commit into from
Oct 6, 2017

Conversation

@bcostm
Copy link
Contributor

@bcostm bcostm commented Oct 4, 2017 •
edited
Loading

Add new NUCLEO boards.

@bridadan bridadan mentioned this pull request Oct 4, 2017
Merged
@theotherjimmy
Copy link
Contributor

theotherjimmy commented Oct 4, 2017

Note that the NUCLEO_L452RE and NUCLEO_L452RE_P was already added in PR #190 but they disappeared in the master branch.

This should no longer be the case. Please reopen if I am mistaken.

@jeromecoutant
Copy link
Contributor

jeromecoutant commented Oct 5, 2017

Hi
Initial goal of this PR was to introduce NUCLEO_L433RC_P :-)

@bridadan
Copy link
Contributor

bridadan commented Oct 5, 2017

Oh oops! Totally missed that, sorry @jeromecoutant. Can we reopen the PR @theotherjimmy?

@theotherjimmy theotherjimmy reopened this Oct 5, 2017
@theotherjimmy
Copy link
Contributor

theotherjimmy commented Oct 5, 2017

Initial goal of this PR was to introduce NUCLEO_L433RC_P :-)

I'd appreciate having that in text in the PR description or title.

@bcostm bcostm changed the title Add more NUCLEO boards Add NUCLEO_L452RE/L452RE_P/L433RC_P/F722ZE/L496ZG/L496ZG_P boards Oct 5, 2017
@theotherjimmy
Copy link
Contributor

theotherjimmy commented Oct 5, 2017

Thanks!

bridadan
bridadan approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All IDs look good! Match with the db

@bridadan
Copy link
Contributor

bridadan commented Oct 5, 2017

Does look like there's a merge conflict though.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 72.783% when pulling 9956fe3 on bcostm:add_nucleo_boards into 447fbf6 on ARMmbed:master.

@bcostm
Copy link
Contributor Author

bcostm commented Oct 6, 2017 •
edited
Loading

No problem @theotherjimmy
I have rebased and solve the conflict but now I see only two lines changed. So the title and description are wrong...

@bcostm bcostm changed the title Add NUCLEO_L452RE/L452RE_P/L433RC_P/F722ZE/L496ZG/L496ZG_P boards Add NUCLEO_L433RC_P and NUCLEO_F722ZE boards Oct 6, 2017
@theotherjimmy
Copy link
Contributor

theotherjimmy commented Oct 6, 2017

Thanks bcostm!

@theotherjimmy theotherjimmy merged commit f189e8b into ARMmbed:master Oct 6, 2017
@bcostm bcostm deleted the add_nucleo_boards branch October 9, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bridadan bridadan bridadan approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bcostm @theotherjimmy @jeromecoutant @bridadan @coveralls