Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Licensing Information #10360

Closed
maxgerhardt opened this issue Apr 9, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@maxgerhardt
Copy link

commented Apr 9, 2019

Description

The LICENCE.md file of mbed-os states: https://github.com/ARMmbed/mbed-os/blob/master/LICENSE.md

Folders containing files under different permissive license than Apache 2.0 are listed below. Each folder should contain its own README file with license specified for its files. The original license text is included in those source files.
[..]
features/storage - BSD-style, MIT

However, looking at the actual source code files of features/storage, lots of them are also Apache 2.0 licensed.

/*
* Copyright (c) 2018 ARM Limited. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
* Licensed under the Apache License, Version 2.0 (the License); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

Can you look over the licenses that subfolder again and correct the LICENSE.md?

Issue request type

[X] Question
[ ] Enhancement
[ ] Bug

@maxgerhardt maxgerhardt changed the title Inconsistent Licensing Unformation Inconsistent Licensing Information Apr 9, 2019

@maxgerhardt

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

@maxgerhardt

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

And the LittleFS C++ class is licensed Apache-2.0 whereas the underlying C implementation is in BSD-3-Clause.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

However, looking at the actual source code files of features/storage, lots of them are also Apache 2.0 licensed.

It's stated in the license file as "Folders containing files under different permissive license than Apache 2.0 are listed below". By default, all files should be Apache 2.0.

To clarify: https://github.com/ARMmbed/mbed-os/blob/master/LICENSE.md - lists folders containing non Apache folders. Each of this folder should contain own license file with more details (list of files, license text) - this still needs to be done for many of these folders.

Also I don't understand why header file https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.h is MIT-licensed and its source code https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.cpp is Apache 2.0 licensed. Huh?

@yossi2le Please fix

And the LittleFS C++ class is licensed Apache-2.0 whereas the underlying C implementation is in BSD-3-Clause.

C implementation is BSD-3-Clause - code comes from external repository. The C++ object for Mbed OS is under Apache 2.0 - as stated above - this is our default license.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@maxgerhardt If you got further questions, let us know.

I'll close this as resolved. Blockdevice file fix is here #10414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.